Commit 183e19f5 authored by Sean Young's avatar Sean Young Committed by Mauro Carvalho Chehab

media: rc: Remove init_ir_raw_event and DEFINE_IR_RAW_EVENT macros

This can be done with c99 initializers, which makes the code cleaner
and more transparent. It does require gcc 4.6, because of this bug
in earlier versions:

	https://gcc.gnu.org/bugzilla/show_bug.cgi?id=10676

Since commit cafa0010 ("Raise the minimum required gcc version to
4.6"), this is the case.
Signed-off-by: default avatarSean Young <sean@mess.org>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab+samsung@kernel.org>
parent c5f14af0
...@@ -45,7 +45,7 @@ int picolcd_raw_cir(struct picolcd_data *data, ...@@ -45,7 +45,7 @@ int picolcd_raw_cir(struct picolcd_data *data,
{ {
unsigned long flags; unsigned long flags;
int i, w, sz; int i, w, sz;
DEFINE_IR_RAW_EVENT(rawir); struct ir_raw_event rawir = {};
/* ignore if rc_dev is NULL or status is shunned */ /* ignore if rc_dev is NULL or status is shunned */
spin_lock_irqsave(&data->lock, flags); spin_lock_irqsave(&data->lock, flags);
...@@ -67,7 +67,6 @@ int picolcd_raw_cir(struct picolcd_data *data, ...@@ -67,7 +67,6 @@ int picolcd_raw_cir(struct picolcd_data *data,
*/ */
sz = size > 0 ? min((int)raw_data[0], size-1) : 0; sz = size > 0 ? min((int)raw_data[0], size-1) : 0;
for (i = 0; i+1 < sz; i += 2) { for (i = 0; i+1 < sz; i += 2) {
init_ir_raw_event(&rawir);
w = (raw_data[i] << 8) | (raw_data[i+1]); w = (raw_data[i] << 8) | (raw_data[i+1]);
rawir.pulse = !!(w & 0x8000); rawir.pulse = !!(w & 0x8000);
rawir.duration = US_TO_NS(rawir.pulse ? (65536 - w) : w); rawir.duration = US_TO_NS(rawir.pulse ? (65536 - w) : w);
......
...@@ -26,10 +26,10 @@ void sms_ir_event(struct smscore_device_t *coredev, const char *buf, int len) ...@@ -26,10 +26,10 @@ void sms_ir_event(struct smscore_device_t *coredev, const char *buf, int len)
const s32 *samples = (const void *)buf; const s32 *samples = (const void *)buf;
for (i = 0; i < len >> 2; i++) { for (i = 0; i < len >> 2; i++) {
DEFINE_IR_RAW_EVENT(ev); struct ir_raw_event ev = {
.duration = abs(samples[i]) * 1000, /* Convert to ns */
ev.duration = abs(samples[i]) * 1000; /* Convert to ns */ .pulse = (samples[i] > 0) ? false : true
ev.pulse = (samples[i] > 0) ? false : true; };
ir_raw_event_store(coredev->ir.dev, &ev); ir_raw_event_store(coredev->ir.dev, &ev);
} }
......
...@@ -701,10 +701,8 @@ static int cx25840_ir_rx_read(struct v4l2_subdev *sd, u8 *buf, size_t count, ...@@ -701,10 +701,8 @@ static int cx25840_ir_rx_read(struct v4l2_subdev *sd, u8 *buf, size_t count,
if (v > IR_MAX_DURATION) if (v > IR_MAX_DURATION)
v = IR_MAX_DURATION; v = IR_MAX_DURATION;
init_ir_raw_event(&p->ir_core_data); p->ir_core_data = (struct ir_raw_event)
p->ir_core_data.pulse = u; { .pulse = u, .duration = v, .timeout = w };
p->ir_core_data.duration = v;
p->ir_core_data.timeout = w;
v4l2_dbg(2, ir_debug, sd, "rx read: %10u ns %s %s\n", v4l2_dbg(2, ir_debug, sd, "rx read: %10u ns %s %s\n",
v, u ? "mark" : "space", w ? "(timed out)" : ""); v, u ? "mark" : "space", w ? "(timed out)" : "");
......
...@@ -696,10 +696,8 @@ static int cx23888_ir_rx_read(struct v4l2_subdev *sd, u8 *buf, size_t count, ...@@ -696,10 +696,8 @@ static int cx23888_ir_rx_read(struct v4l2_subdev *sd, u8 *buf, size_t count,
if (v > IR_MAX_DURATION) if (v > IR_MAX_DURATION)
v = IR_MAX_DURATION; v = IR_MAX_DURATION;
init_ir_raw_event(&p->ir_core_data); p->ir_core_data = (struct ir_raw_event)
p->ir_core_data.pulse = u; { .pulse = u, .duration = v, .timeout = w };
p->ir_core_data.duration = v;
p->ir_core_data.timeout = w;
v4l2_dbg(2, ir_888_debug, sd, "rx read: %10u ns %s %s\n", v4l2_dbg(2, ir_888_debug, sd, "rx read: %10u ns %s %s\n",
v, u ? "mark" : "space", w ? "(timed out)" : ""); v, u ? "mark" : "space", w ? "(timed out)" : "");
......
...@@ -535,7 +535,7 @@ void cx88_ir_irq(struct cx88_core *core) ...@@ -535,7 +535,7 @@ void cx88_ir_irq(struct cx88_core *core)
struct cx88_IR *ir = core->ir; struct cx88_IR *ir = core->ir;
u32 samples; u32 samples;
unsigned int todo, bits; unsigned int todo, bits;
struct ir_raw_event ev; struct ir_raw_event ev = {};
if (!ir || !ir->sampling) if (!ir || !ir->sampling)
return; return;
...@@ -550,7 +550,6 @@ void cx88_ir_irq(struct cx88_core *core) ...@@ -550,7 +550,6 @@ void cx88_ir_irq(struct cx88_core *core)
if (samples == 0xff && ir->dev->idle) if (samples == 0xff && ir->dev->idle)
return; return;
init_ir_raw_event(&ev);
for (todo = 32; todo > 0; todo -= bits) { for (todo = 32; todo > 0; todo -= bits) {
ev.pulse = samples & 0x80000000 ? false : true; ev.pulse = samples & 0x80000000 ? false : true;
bits = min(todo, 32U - fls(ev.pulse ? samples : ~samples)); bits = min(todo, 32U - fls(ev.pulse ? samples : ~samples));
......
...@@ -326,8 +326,6 @@ static int ene_rx_get_sample_reg(struct ene_device *dev) ...@@ -326,8 +326,6 @@ static int ene_rx_get_sample_reg(struct ene_device *dev)
/* Sense current received carrier */ /* Sense current received carrier */
static void ene_rx_sense_carrier(struct ene_device *dev) static void ene_rx_sense_carrier(struct ene_device *dev)
{ {
DEFINE_IR_RAW_EVENT(ev);
int carrier, duty_cycle; int carrier, duty_cycle;
int period = ene_read_reg(dev, ENE_CIRCAR_PRD); int period = ene_read_reg(dev, ENE_CIRCAR_PRD);
int hperiod = ene_read_reg(dev, ENE_CIRCAR_HPRD); int hperiod = ene_read_reg(dev, ENE_CIRCAR_HPRD);
...@@ -348,9 +346,11 @@ static void ene_rx_sense_carrier(struct ene_device *dev) ...@@ -348,9 +346,11 @@ static void ene_rx_sense_carrier(struct ene_device *dev)
dbg("RX: sensed carrier = %d Hz, duty cycle %d%%", dbg("RX: sensed carrier = %d Hz, duty cycle %d%%",
carrier, duty_cycle); carrier, duty_cycle);
if (dev->carrier_detect_enabled) { if (dev->carrier_detect_enabled) {
ev.carrier_report = true; struct ir_raw_event ev = {
ev.carrier = carrier; .carrier_report = true,
ev.duty_cycle = duty_cycle; .carrier = carrier,
.duty_cycle = duty_cycle
};
ir_raw_event_store(dev->rdev, &ev); ir_raw_event_store(dev->rdev, &ev);
} }
} }
...@@ -733,7 +733,7 @@ static irqreturn_t ene_isr(int irq, void *data) ...@@ -733,7 +733,7 @@ static irqreturn_t ene_isr(int irq, void *data)
unsigned long flags; unsigned long flags;
irqreturn_t retval = IRQ_NONE; irqreturn_t retval = IRQ_NONE;
struct ene_device *dev = (struct ene_device *)data; struct ene_device *dev = (struct ene_device *)data;
DEFINE_IR_RAW_EVENT(ev); struct ir_raw_event ev = {};
spin_lock_irqsave(&dev->hw_lock, flags); spin_lock_irqsave(&dev->hw_lock, flags);
......
...@@ -282,7 +282,7 @@ static int fintek_cmdsize(u8 cmd, u8 subcmd) ...@@ -282,7 +282,7 @@ static int fintek_cmdsize(u8 cmd, u8 subcmd)
/* process ir data stored in driver buffer */ /* process ir data stored in driver buffer */
static void fintek_process_rx_ir_data(struct fintek_dev *fintek) static void fintek_process_rx_ir_data(struct fintek_dev *fintek)
{ {
DEFINE_IR_RAW_EVENT(rawir); struct ir_raw_event rawir = {};
u8 sample; u8 sample;
bool event = false; bool event = false;
int i; int i;
...@@ -314,7 +314,6 @@ static void fintek_process_rx_ir_data(struct fintek_dev *fintek) ...@@ -314,7 +314,6 @@ static void fintek_process_rx_ir_data(struct fintek_dev *fintek)
break; break;
case PARSE_IRDATA: case PARSE_IRDATA:
fintek->rem--; fintek->rem--;
init_ir_raw_event(&rawir);
rawir.pulse = ((sample & BUF_PULSE_BIT) != 0); rawir.pulse = ((sample & BUF_PULSE_BIT) != 0);
rawir.duration = US_TO_NS((sample & BUF_SAMPLE_MASK) rawir.duration = US_TO_NS((sample & BUF_SAMPLE_MASK)
* CIR_SAMPLE_PERIOD); * CIR_SAMPLE_PERIOD);
......
...@@ -56,7 +56,7 @@ static void igorplugusb_cmd(struct igorplugusb *ir, int cmd); ...@@ -56,7 +56,7 @@ static void igorplugusb_cmd(struct igorplugusb *ir, int cmd);
static void igorplugusb_irdata(struct igorplugusb *ir, unsigned len) static void igorplugusb_irdata(struct igorplugusb *ir, unsigned len)
{ {
DEFINE_IR_RAW_EVENT(rawir); struct ir_raw_event rawir = {};
unsigned i, start, overflow; unsigned i, start, overflow;
dev_dbg(ir->dev, "irdata: %*ph (len=%u)", len, ir->buf_in, len); dev_dbg(ir->dev, "irdata: %*ph (len=%u)", len, ir->buf_in, len);
......
...@@ -129,12 +129,10 @@ static void process_ir_data(struct iguanair *ir, unsigned len) ...@@ -129,12 +129,10 @@ static void process_ir_data(struct iguanair *ir, unsigned len)
break; break;
} }
} else if (len >= 7) { } else if (len >= 7) {
DEFINE_IR_RAW_EVENT(rawir); struct ir_raw_event rawir = {};
unsigned i; unsigned i;
bool event = false; bool event = false;
init_ir_raw_event(&rawir);
for (i = 0; i < 7; i++) { for (i = 0; i < 7; i++) {
if (ir->buf_in[i] == 0x80) { if (ir->buf_in[i] == 0x80) {
rawir.pulse = false; rawir.pulse = false;
......
...@@ -28,7 +28,7 @@ static inline int is_bit_set(const u8 *buf, int bit) ...@@ -28,7 +28,7 @@ static inline int is_bit_set(const u8 *buf, int bit)
static void imon_ir_data(struct imon *imon) static void imon_ir_data(struct imon *imon)
{ {
DEFINE_IR_RAW_EVENT(rawir); struct ir_raw_event rawir = {};
int offset = 0, size = 5 * 8; int offset = 0, size = 5 * 8;
int bit; int bit;
......
...@@ -175,7 +175,7 @@ static irqreturn_t hix5hd2_ir_rx_interrupt(int irq, void *data) ...@@ -175,7 +175,7 @@ static irqreturn_t hix5hd2_ir_rx_interrupt(int irq, void *data)
} }
if ((irq_sr & INTMS_SYMBRCV) || (irq_sr & INTMS_TIMEOUT)) { if ((irq_sr & INTMS_SYMBRCV) || (irq_sr & INTMS_TIMEOUT)) {
DEFINE_IR_RAW_EVENT(ev); struct ir_raw_event ev = {};
symb_num = readl_relaxed(priv->base + IR_DATAH); symb_num = readl_relaxed(priv->base + IR_DATAH);
for (i = 0; i < symb_num; i++) { for (i = 0; i < symb_num; i++) {
......
...@@ -173,7 +173,7 @@ static void ite_decode_bytes(struct ite_dev *dev, const u8 * data, int ...@@ -173,7 +173,7 @@ static void ite_decode_bytes(struct ite_dev *dev, const u8 * data, int
u32 sample_period; u32 sample_period;
unsigned long *ldata; unsigned long *ldata;
unsigned int next_one, next_zero, size; unsigned int next_one, next_zero, size;
DEFINE_IR_RAW_EVENT(ev); struct ir_raw_event ev = {};
if (length == 0) if (length == 0)
return; return;
...@@ -1507,9 +1507,6 @@ static int ite_probe(struct pnp_dev *pdev, const struct pnp_device_id ...@@ -1507,9 +1507,6 @@ static int ite_probe(struct pnp_dev *pdev, const struct pnp_device_id
/* initialize spinlocks */ /* initialize spinlocks */
spin_lock_init(&itdev->lock); spin_lock_init(&itdev->lock);
/* initialize raw event */
init_ir_raw_event(&itdev->rawir);
/* set driver data into the pnp device */ /* set driver data into the pnp device */
pnp_set_drvdata(pdev, itdev); pnp_set_drvdata(pdev, itdev);
itdev->pdev = pdev; itdev->pdev = pdev;
......
...@@ -1078,7 +1078,7 @@ static int mceusb_set_rx_carrier_report(struct rc_dev *dev, int enable) ...@@ -1078,7 +1078,7 @@ static int mceusb_set_rx_carrier_report(struct rc_dev *dev, int enable)
*/ */
static void mceusb_handle_command(struct mceusb_dev *ir, int index) static void mceusb_handle_command(struct mceusb_dev *ir, int index)
{ {
DEFINE_IR_RAW_EVENT(rawir); struct ir_raw_event rawir = {};
u8 hi = ir->buf_in[index + 1] & 0xff; u8 hi = ir->buf_in[index + 1] & 0xff;
u8 lo = ir->buf_in[index + 2] & 0xff; u8 lo = ir->buf_in[index + 2] & 0xff;
u32 carrier_cycles; u32 carrier_cycles;
...@@ -1152,7 +1152,7 @@ static void mceusb_handle_command(struct mceusb_dev *ir, int index) ...@@ -1152,7 +1152,7 @@ static void mceusb_handle_command(struct mceusb_dev *ir, int index)
static void mceusb_process_ir_data(struct mceusb_dev *ir, int buf_len) static void mceusb_process_ir_data(struct mceusb_dev *ir, int buf_len)
{ {
DEFINE_IR_RAW_EVENT(rawir); struct ir_raw_event rawir = {};
bool event = false; bool event = false;
int i = 0; int i = 0;
...@@ -1175,7 +1175,6 @@ static void mceusb_process_ir_data(struct mceusb_dev *ir, int buf_len) ...@@ -1175,7 +1175,6 @@ static void mceusb_process_ir_data(struct mceusb_dev *ir, int buf_len)
break; break;
case PARSE_IRDATA: case PARSE_IRDATA:
ir->rem--; ir->rem--;
init_ir_raw_event(&rawir);
rawir.pulse = ((ir->buf_in[i] & MCE_PULSE_BIT) != 0); rawir.pulse = ((ir->buf_in[i] & MCE_PULSE_BIT) != 0);
rawir.duration = (ir->buf_in[i] & MCE_PULSE_MASK); rawir.duration = (ir->buf_in[i] & MCE_PULSE_MASK);
if (unlikely(!rawir.duration)) { if (unlikely(!rawir.duration)) {
...@@ -1215,11 +1214,13 @@ static void mceusb_process_ir_data(struct mceusb_dev *ir, int buf_len) ...@@ -1215,11 +1214,13 @@ static void mceusb_process_ir_data(struct mceusb_dev *ir, int buf_len)
if (ir->rem) { if (ir->rem) {
ir->parser_state = PARSE_IRDATA; ir->parser_state = PARSE_IRDATA;
} else { } else {
init_ir_raw_event(&rawir); struct ir_raw_event ev = {
rawir.timeout = 1; .timeout = 1,
rawir.duration = ir->rc->timeout; .duration = ir->rc->timeout
};
if (ir_raw_event_store_with_filter(ir->rc, if (ir_raw_event_store_with_filter(ir->rc,
&rawir)) &ev))
event = true; event = true;
ir->pulse_tunit = 0; ir->pulse_tunit = 0;
ir->pulse_count = 0; ir->pulse_count = 0;
......
...@@ -86,7 +86,7 @@ static irqreturn_t meson_ir_irq(int irqno, void *dev_id) ...@@ -86,7 +86,7 @@ static irqreturn_t meson_ir_irq(int irqno, void *dev_id)
{ {
struct meson_ir *ir = dev_id; struct meson_ir *ir = dev_id;
u32 duration, status; u32 duration, status;
DEFINE_IR_RAW_EVENT(rawir); struct ir_raw_event rawir = {};
spin_lock(&ir->lock); spin_lock(&ir->lock);
......
...@@ -212,7 +212,7 @@ static irqreturn_t mtk_ir_irq(int irqno, void *dev_id) ...@@ -212,7 +212,7 @@ static irqreturn_t mtk_ir_irq(int irqno, void *dev_id)
struct mtk_ir *ir = dev_id; struct mtk_ir *ir = dev_id;
u8 wid = 0; u8 wid = 0;
u32 i, j, val; u32 i, j, val;
DEFINE_IR_RAW_EVENT(rawir); struct ir_raw_event rawir = {};
/* /*
* Reset decoder state machine explicitly is required * Reset decoder state machine explicitly is required
......
...@@ -737,7 +737,7 @@ static void nvt_dump_rx_buf(struct nvt_dev *nvt) ...@@ -737,7 +737,7 @@ static void nvt_dump_rx_buf(struct nvt_dev *nvt)
*/ */
static void nvt_process_rx_ir_data(struct nvt_dev *nvt) static void nvt_process_rx_ir_data(struct nvt_dev *nvt)
{ {
DEFINE_IR_RAW_EVENT(rawir); struct ir_raw_event rawir = {};
u8 sample; u8 sample;
int i; int i;
......
...@@ -181,9 +181,10 @@ static inline void init_ir_raw_event_duration(struct ir_raw_event *ev, ...@@ -181,9 +181,10 @@ static inline void init_ir_raw_event_duration(struct ir_raw_event *ev,
unsigned int pulse, unsigned int pulse,
u32 duration) u32 duration)
{ {
init_ir_raw_event(ev); *ev = (struct ir_raw_event) {
ev->duration = duration; .duration = duration,
ev->pulse = pulse; .pulse = pulse
};
} }
/** /**
......
...@@ -102,7 +102,7 @@ EXPORT_SYMBOL_GPL(ir_raw_event_store); ...@@ -102,7 +102,7 @@ EXPORT_SYMBOL_GPL(ir_raw_event_store);
int ir_raw_event_store_edge(struct rc_dev *dev, bool pulse) int ir_raw_event_store_edge(struct rc_dev *dev, bool pulse)
{ {
ktime_t now; ktime_t now;
DEFINE_IR_RAW_EVENT(ev); struct ir_raw_event ev = {};
if (!dev->raw) if (!dev->raw)
return -EINVAL; return -EINVAL;
...@@ -210,7 +210,7 @@ void ir_raw_event_set_idle(struct rc_dev *dev, bool idle) ...@@ -210,7 +210,7 @@ void ir_raw_event_set_idle(struct rc_dev *dev, bool idle)
if (idle) { if (idle) {
dev->raw->this_ev.timeout = true; dev->raw->this_ev.timeout = true;
ir_raw_event_store(dev, &dev->raw->this_ev); ir_raw_event_store(dev, &dev->raw->this_ev);
init_ir_raw_event(&dev->raw->this_ev); dev->raw->this_ev = (struct ir_raw_event) {};
} }
if (dev->s_idle) if (dev->s_idle)
...@@ -562,10 +562,10 @@ static void ir_raw_edge_handle(struct timer_list *t) ...@@ -562,10 +562,10 @@ static void ir_raw_edge_handle(struct timer_list *t)
spin_lock_irqsave(&dev->raw->edge_spinlock, flags); spin_lock_irqsave(&dev->raw->edge_spinlock, flags);
interval = ktime_sub(ktime_get(), dev->raw->last_event); interval = ktime_sub(ktime_get(), dev->raw->last_event);
if (ktime_to_ns(interval) >= dev->timeout) { if (ktime_to_ns(interval) >= dev->timeout) {
DEFINE_IR_RAW_EVENT(ev); struct ir_raw_event ev = {
.timeout = true,
ev.timeout = true; .duration = ktime_to_ns(interval)
ev.duration = ktime_to_ns(interval); };
ir_raw_event_store(dev, &ev); ir_raw_event_store(dev, &ev);
} else { } else {
......
...@@ -103,7 +103,7 @@ static int loop_tx_ir(struct rc_dev *dev, unsigned *txbuf, unsigned count) ...@@ -103,7 +103,7 @@ static int loop_tx_ir(struct rc_dev *dev, unsigned *txbuf, unsigned count)
struct loopback_dev *lodev = dev->priv; struct loopback_dev *lodev = dev->priv;
u32 rxmask; u32 rxmask;
unsigned i; unsigned i;
DEFINE_IR_RAW_EVENT(rawir); struct ir_raw_event rawir = {};
if (lodev->txcarrier < lodev->rxcarriermin || if (lodev->txcarrier < lodev->rxcarriermin ||
lodev->txcarrier > lodev->rxcarriermax) { lodev->txcarrier > lodev->rxcarriermax) {
......
...@@ -348,7 +348,7 @@ static u32 redrat3_us_to_len(u32 microsec) ...@@ -348,7 +348,7 @@ static u32 redrat3_us_to_len(u32 microsec)
static void redrat3_process_ir_data(struct redrat3_dev *rr3) static void redrat3_process_ir_data(struct redrat3_dev *rr3)
{ {
DEFINE_IR_RAW_EVENT(rawir); struct ir_raw_event rawir = {};
struct device *dev; struct device *dev;
unsigned int i, sig_size, single_len, offset, val; unsigned int i, sig_size, single_len, offset, val;
u32 mod_freq; u32 mod_freq;
...@@ -358,10 +358,10 @@ static void redrat3_process_ir_data(struct redrat3_dev *rr3) ...@@ -358,10 +358,10 @@ static void redrat3_process_ir_data(struct redrat3_dev *rr3)
mod_freq = redrat3_val_to_mod_freq(&rr3->irdata); mod_freq = redrat3_val_to_mod_freq(&rr3->irdata);
dev_dbg(dev, "Got mod_freq of %u\n", mod_freq); dev_dbg(dev, "Got mod_freq of %u\n", mod_freq);
if (mod_freq && rr3->wideband) { if (mod_freq && rr3->wideband) {
DEFINE_IR_RAW_EVENT(ev); struct ir_raw_event ev = {
.carrier_report = 1,
ev.carrier_report = 1; .carrier = mod_freq
ev.carrier = mod_freq; };
ir_raw_event_store(rr3->rc, &ev); ir_raw_event_store(rr3->rc, &ev);
} }
......
...@@ -273,7 +273,7 @@ static void frbwrite(unsigned int l, bool is_pulse) ...@@ -273,7 +273,7 @@ static void frbwrite(unsigned int l, bool is_pulse)
{ {
/* simple noise filter */ /* simple noise filter */
static unsigned int ptr, pulse, space; static unsigned int ptr, pulse, space;
DEFINE_IR_RAW_EVENT(ev); struct ir_raw_event ev = {};
if (ptr > 0 && is_pulse) { if (ptr > 0 && is_pulse) {
pulse += l; pulse += l;
...@@ -472,10 +472,10 @@ static int hardware_init_port(void) ...@@ -472,10 +472,10 @@ static int hardware_init_port(void)
static void serial_ir_timeout(struct timer_list *unused) static void serial_ir_timeout(struct timer_list *unused)
{ {
DEFINE_IR_RAW_EVENT(ev); struct ir_raw_event ev = {
.timeout = true,
ev.timeout = true; .duration = serial_ir.rcdev->timeout
ev.duration = serial_ir.rcdev->timeout; };
ir_raw_event_store_with_filter(serial_ir.rcdev, &ev); ir_raw_event_store_with_filter(serial_ir.rcdev, &ev);
ir_raw_event_handle(serial_ir.rcdev); ir_raw_event_handle(serial_ir.rcdev);
} }
......
...@@ -96,7 +96,7 @@ static int sir_tx_ir(struct rc_dev *dev, unsigned int *tx_buf, ...@@ -96,7 +96,7 @@ static int sir_tx_ir(struct rc_dev *dev, unsigned int *tx_buf,
static void add_read_queue(int flag, unsigned long val) static void add_read_queue(int flag, unsigned long val)
{ {
DEFINE_IR_RAW_EVENT(ev); struct ir_raw_event ev = {};
pr_debug("add flag %d with val %lu\n", flag, val); pr_debug("add flag %d with val %lu\n", flag, val);
......
...@@ -67,8 +67,7 @@ struct st_rc_device { ...@@ -67,8 +67,7 @@ struct st_rc_device {
static void st_rc_send_lirc_timeout(struct rc_dev *rdev) static void st_rc_send_lirc_timeout(struct rc_dev *rdev)
{ {
DEFINE_IR_RAW_EVENT(ev); struct ir_raw_event ev = { .timeout = true, .duration = rdev->timeout };
ev.timeout = true;
ir_raw_event_store(rdev, &ev); ir_raw_event_store(rdev, &ev);
} }
...@@ -101,7 +100,7 @@ static irqreturn_t st_rc_rx_interrupt(int irq, void *data) ...@@ -101,7 +100,7 @@ static irqreturn_t st_rc_rx_interrupt(int irq, void *data)
struct st_rc_device *dev = data; struct st_rc_device *dev = data;
int last_symbol = 0; int last_symbol = 0;
u32 status, int_status; u32 status, int_status;
DEFINE_IR_RAW_EVENT(ev); struct ir_raw_event ev = {};
if (dev->irq_wake) if (dev->irq_wake)
pm_wakeup_event(dev->dev, 0); pm_wakeup_event(dev->dev, 0);
......
...@@ -130,7 +130,7 @@ static void sz_push(struct streamzap_ir *sz, struct ir_raw_event rawir) ...@@ -130,7 +130,7 @@ static void sz_push(struct streamzap_ir *sz, struct ir_raw_event rawir)
static void sz_push_full_pulse(struct streamzap_ir *sz, static void sz_push_full_pulse(struct streamzap_ir *sz,
unsigned char value) unsigned char value)
{ {
DEFINE_IR_RAW_EVENT(rawir); struct ir_raw_event rawir = {};
if (sz->idle) { if (sz->idle) {
int delta; int delta;
...@@ -175,7 +175,7 @@ static void sz_push_half_pulse(struct streamzap_ir *sz, ...@@ -175,7 +175,7 @@ static void sz_push_half_pulse(struct streamzap_ir *sz,
static void sz_push_full_space(struct streamzap_ir *sz, static void sz_push_full_space(struct streamzap_ir *sz,
unsigned char value) unsigned char value)
{ {
DEFINE_IR_RAW_EVENT(rawir); struct ir_raw_event rawir = {};
rawir.pulse = false; rawir.pulse = false;
rawir.duration = ((int) value) * SZ_RESOLUTION; rawir.duration = ((int) value) * SZ_RESOLUTION;
...@@ -249,10 +249,10 @@ static void streamzap_callback(struct urb *urb) ...@@ -249,10 +249,10 @@ static void streamzap_callback(struct urb *urb)
break; break;
case FullSpace: case FullSpace:
if (sz->buf_in[i] == SZ_TIMEOUT) { if (sz->buf_in[i] == SZ_TIMEOUT) {
DEFINE_IR_RAW_EVENT(rawir); struct ir_raw_event rawir = {
.pulse = false,
rawir.pulse = false; .duration = sz->rdev->timeout
rawir.duration = sz->rdev->timeout; };
sz->idle = true; sz->idle = true;
if (sz->timeout_enabled) if (sz->timeout_enabled)
sz_push(sz, rawir); sz_push(sz, rawir);
......
...@@ -99,7 +99,7 @@ static irqreturn_t sunxi_ir_irq(int irqno, void *dev_id) ...@@ -99,7 +99,7 @@ static irqreturn_t sunxi_ir_irq(int irqno, void *dev_id)
unsigned char dt; unsigned char dt;
unsigned int cnt, rc; unsigned int cnt, rc;
struct sunxi_ir *ir = dev_id; struct sunxi_ir *ir = dev_id;
DEFINE_IR_RAW_EVENT(rawir); struct ir_raw_event rawir = {};
spin_lock(&ir->ir_lock); spin_lock(&ir->ir_lock);
......
...@@ -117,12 +117,10 @@ static void ttusbir_bulk_complete(struct urb *urb) ...@@ -117,12 +117,10 @@ static void ttusbir_bulk_complete(struct urb *urb)
*/ */
static void ttusbir_process_ir_data(struct ttusbir *tt, uint8_t *buf) static void ttusbir_process_ir_data(struct ttusbir *tt, uint8_t *buf)
{ {
struct ir_raw_event rawir; struct ir_raw_event rawir = {};
unsigned i, v, b; unsigned i, v, b;
bool event = false; bool event = false;
init_ir_raw_event(&rawir);
for (i = 0; i < 128; i++) { for (i = 0; i < 128; i++) {
v = buf[i] & 0xfe; v = buf[i] & 0xfe;
switch (v) { switch (v) {
......
...@@ -322,11 +322,11 @@ wbcir_carrier_report(struct wbcir_data *data) ...@@ -322,11 +322,11 @@ wbcir_carrier_report(struct wbcir_data *data)
inb(data->ebase + WBCIR_REG_ECEIR_CNT_HI) << 8; inb(data->ebase + WBCIR_REG_ECEIR_CNT_HI) << 8;
if (counter > 0 && counter < 0xffff) { if (counter > 0 && counter < 0xffff) {
DEFINE_IR_RAW_EVENT(ev); struct ir_raw_event ev = {
.carrier_report = 1,
ev.carrier_report = 1; .carrier = DIV_ROUND_CLOSEST(counter * 1000000u,
ev.carrier = DIV_ROUND_CLOSEST(counter * 1000000u, data->pulse_duration)
data->pulse_duration); };
ir_raw_event_store(data->dev, &ev); ir_raw_event_store(data->dev, &ev);
} }
...@@ -362,7 +362,7 @@ static void ...@@ -362,7 +362,7 @@ static void
wbcir_irq_rx(struct wbcir_data *data, struct pnp_dev *device) wbcir_irq_rx(struct wbcir_data *data, struct pnp_dev *device)
{ {
u8 irdata; u8 irdata;
DEFINE_IR_RAW_EVENT(rawir); struct ir_raw_event rawir = {};
unsigned duration; unsigned duration;
/* Since RXHDLEV is set, at least 8 bytes are in the FIFO */ /* Since RXHDLEV is set, at least 8 bytes are in the FIFO */
......
...@@ -113,7 +113,7 @@ static int au8522_rc_andor(struct au0828_rc *ir, u16 reg, u8 mask, u8 value) ...@@ -113,7 +113,7 @@ static int au8522_rc_andor(struct au0828_rc *ir, u16 reg, u8 mask, u8 value)
static int au0828_get_key_au8522(struct au0828_rc *ir) static int au0828_get_key_au8522(struct au0828_rc *ir)
{ {
unsigned char buf[40]; unsigned char buf[40];
DEFINE_IR_RAW_EVENT(rawir); struct ir_raw_event rawir = {};
int i, j, rc; int i, j, rc;
int prv_bit, bit, width; int prv_bit, bit, width;
bool first = true; bool first = true;
...@@ -167,7 +167,6 @@ static int au0828_get_key_au8522(struct au0828_rc *ir) ...@@ -167,7 +167,6 @@ static int au0828_get_key_au8522(struct au0828_rc *ir)
if (first) { if (first) {
first = false; first = false;
init_ir_raw_event(&rawir);
rawir.pulse = true; rawir.pulse = true;
if (width > NEC_START_SPACE - 2 && if (width > NEC_START_SPACE - 2 &&
width < NEC_START_SPACE + 2) { width < NEC_START_SPACE + 2) {
...@@ -186,7 +185,6 @@ static int au0828_get_key_au8522(struct au0828_rc *ir) ...@@ -186,7 +185,6 @@ static int au0828_get_key_au8522(struct au0828_rc *ir)
ir_raw_event_store(ir->rc, &rawir); ir_raw_event_store(ir->rc, &rawir);
} }
init_ir_raw_event(&rawir);
rawir.pulse = prv_bit ? false : true; rawir.pulse = prv_bit ? false : true;
rawir.duration = AU8522_UNIT * width; rawir.duration = AU8522_UNIT * width;
dprintk(16, "Storing %s with duration %d", dprintk(16, "Storing %s with duration %d",
...@@ -199,7 +197,6 @@ static int au0828_get_key_au8522(struct au0828_rc *ir) ...@@ -199,7 +197,6 @@ static int au0828_get_key_au8522(struct au0828_rc *ir)
} }
} }
init_ir_raw_event(&rawir);
rawir.pulse = prv_bit ? false : true; rawir.pulse = prv_bit ? false : true;
rawir.duration = AU8522_UNIT * width; rawir.duration = AU8522_UNIT * width;
dprintk(16, "Storing end %s with duration %d", dprintk(16, "Storing end %s with duration %d",
......
...@@ -1685,7 +1685,7 @@ static int rtl2832u_rc_query(struct dvb_usb_device *d) ...@@ -1685,7 +1685,7 @@ static int rtl2832u_rc_query(struct dvb_usb_device *d)
{ {
int ret, i, len; int ret, i, len;
struct rtl28xxu_dev *dev = d->priv; struct rtl28xxu_dev *dev = d->priv;
struct ir_raw_event ev; struct ir_raw_event ev = {};
u8 buf[128]; u8 buf[128];
static const struct rtl28xxu_reg_val_mask refresh_tab[] = { static const struct rtl28xxu_reg_val_mask refresh_tab[] = {
{IR_RX_IF, 0x03, 0xff}, {IR_RX_IF, 0x03, 0xff},
...@@ -1751,8 +1751,6 @@ static int rtl2832u_rc_query(struct dvb_usb_device *d) ...@@ -1751,8 +1751,6 @@ static int rtl2832u_rc_query(struct dvb_usb_device *d)
} }
/* pass data to Kernel IR decoder */ /* pass data to Kernel IR decoder */
init_ir_raw_event(&ev);
for (i = 0; i < len; i++) { for (i = 0; i < len; i++) {
ev.pulse = buf[i] >> 7; ev.pulse = buf[i] >> 7;
ev.duration = 50800 * (buf[i] & 0x7f); ev.duration = 50800 * (buf[i] & 0x7f);
......
...@@ -317,13 +317,6 @@ struct ir_raw_event { ...@@ -317,13 +317,6 @@ struct ir_raw_event {
unsigned carrier_report:1; unsigned carrier_report:1;
}; };
#define DEFINE_IR_RAW_EVENT(event) struct ir_raw_event event = {}
static inline void init_ir_raw_event(struct ir_raw_event *ev)
{
memset(ev, 0, sizeof(*ev));
}
#define IR_DEFAULT_TIMEOUT MS_TO_NS(125) #define IR_DEFAULT_TIMEOUT MS_TO_NS(125)
#define IR_MAX_DURATION 500000000 /* 500 ms */ #define IR_MAX_DURATION 500000000 /* 500 ms */
#define US_TO_NS(usec) ((usec) * 1000) #define US_TO_NS(usec) ((usec) * 1000)
...@@ -344,9 +337,7 @@ int ir_raw_encode_carrier(enum rc_proto protocol); ...@@ -344,9 +337,7 @@ int ir_raw_encode_carrier(enum rc_proto protocol);
static inline void ir_raw_event_reset(struct rc_dev *dev) static inline void ir_raw_event_reset(struct rc_dev *dev)
{ {
struct ir_raw_event ev = { .reset = true }; ir_raw_event_store(dev, &((struct ir_raw_event) { .reset = true }));
ir_raw_event_store(dev, &ev);
dev->idle = true; dev->idle = true;
ir_raw_event_handle(dev); ir_raw_event_handle(dev);
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment