Commit 1861a7f0 authored by Yangtao Li's avatar Yangtao Li Committed by Florian Fainelli

soc: bcm: brcmstb: Don't leak device tree node reference

of_find_node_by_path() acquires a reference to the node returned by it
and that reference needs to be dropped by its caller. soc_is_brcmstb()
doesn't do that, so fix it.

[treding: slightly rewrite to avoid inline comparison]

Fixes: d52fad26 ("soc: add stubs for brcmstb SoC's")
Signed-off-by: default avatarYangtao Li <tiny.windzz@gmail.com>
Signed-off-by: default avatarFlorian Fainelli <f.fainelli@gmail.com>
parent 34758f81
...@@ -31,13 +31,17 @@ static const struct of_device_id brcmstb_machine_match[] = { ...@@ -31,13 +31,17 @@ static const struct of_device_id brcmstb_machine_match[] = {
bool soc_is_brcmstb(void) bool soc_is_brcmstb(void)
{ {
const struct of_device_id *match;
struct device_node *root; struct device_node *root;
root = of_find_node_by_path("/"); root = of_find_node_by_path("/");
if (!root) if (!root)
return false; return false;
return of_match_node(brcmstb_machine_match, root) != NULL; match = of_match_node(brcmstb_machine_match, root);
of_node_put(root);
return match != NULL;
} }
u32 brcmstb_get_family_id(void) u32 brcmstb_get_family_id(void)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment