Commit 188942f0 authored by Serge Semin's avatar Serge Semin Committed by Thomas Bogendoerfer

tty: mips_ejtag_fdc: Fix passing incompatible pointer type warning

mips_ejtag_fdc_encode() method expects having a first argument passed of
the "u8 **" type, meanwhile the driver passes the "const char **" type.
That causes the next build-warning:

drivers/tty/mips_ejtag_fdc.c: In function ‘mips_ejtag_fdc_console_write’:
drivers/tty/mips_ejtag_fdc.c:343:32: error: passing argument 1 of ‘mips_ejtag_fdc_encode’ from incompatible pointer type [-Werror=incompatible-pointer-types]
   word = mips_ejtag_fdc_encode(&buf_ptr, &buf_len, 1);
                                ^
drivers/tty/mips_ejtag_fdc.c:216:24: note: expected ‘const u8 ** {aka const unsigned char **}’ but argument is of type ‘const char **’
 static struct fdc_word mips_ejtag_fdc_encode(const u8 **ptrs,
                        ^~~~~~~~~~~~~~~~~~~~~

Fix it by altering the type of the pointer which is passed to the
mips_ejtag_fdc_encode() method.

Fixes: ce7cbd9a ("tty: mips_ejtag_fdc: use u8 for character pointers")
Signed-off-by: default avatarSerge Semin <fancer.lancer@gmail.com>
Signed-off-by: default avatarThomas Bogendoerfer <tsbogend@alpha.franken.de>
parent 6d778f61
...@@ -309,7 +309,7 @@ static void mips_ejtag_fdc_console_write(struct console *c, const char *s, ...@@ -309,7 +309,7 @@ static void mips_ejtag_fdc_console_write(struct console *c, const char *s,
unsigned int i, buf_len, cpu; unsigned int i, buf_len, cpu;
bool done_cr = false; bool done_cr = false;
char buf[4]; char buf[4];
const char *buf_ptr = buf; const u8 *buf_ptr = buf;
/* Number of bytes of input data encoded up to each byte in buf */ /* Number of bytes of input data encoded up to each byte in buf */
u8 inc[4]; u8 inc[4];
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment