Commit 1c17abbc authored by Cai Huoqing's avatar Cai Huoqing Committed by Jonathan Cameron

iio: adc: imx7d_adc: Make use of the helper function dev_err_probe()

When possible use dev_err_probe help to properly deal with the
PROBE_DEFER error, the benefit is that DEFER issue will be logged
in the devices_deferred debugfs file.
Using dev_err_probe() can reduce code size, and the error value
gets printed.
Signed-off-by: default avatarCai Huoqing <caihuoqing@baidu.com>
Link: https://lore.kernel.org/r/20211008092858.495-2-caihuoqing@baidu.comSigned-off-by: default avatarJonathan Cameron <Jonathan.Cameron@huawei.com>
parent 08e9734a
...@@ -493,22 +493,16 @@ static int imx7d_adc_probe(struct platform_device *pdev) ...@@ -493,22 +493,16 @@ static int imx7d_adc_probe(struct platform_device *pdev)
irq = platform_get_irq(pdev, 0); irq = platform_get_irq(pdev, 0);
if (irq < 0) if (irq < 0)
return irq; return dev_err_probe(dev, irq, "Failed getting irq\n");
info->clk = devm_clk_get(dev, "adc"); info->clk = devm_clk_get(dev, "adc");
if (IS_ERR(info->clk)) { if (IS_ERR(info->clk))
ret = PTR_ERR(info->clk); return dev_err_probe(dev, PTR_ERR(info->clk), "Failed getting clock\n");
dev_err(dev, "Failed getting clock, err = %d\n", ret);
return ret;
}
info->vref = devm_regulator_get(dev, "vref"); info->vref = devm_regulator_get(dev, "vref");
if (IS_ERR(info->vref)) { if (IS_ERR(info->vref))
ret = PTR_ERR(info->vref); return dev_err_probe(dev, PTR_ERR(info->vref),
dev_err(dev, "Failed getting reference voltage\n");
"Failed getting reference voltage, err = %d\n", ret);
return ret;
}
platform_set_drvdata(pdev, indio_dev); platform_set_drvdata(pdev, indio_dev);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment