Commit 1f85ed7d authored by Uwe Kleine-König's avatar Uwe Kleine-König Committed by Mark Brown

spi: lantiq-ssc: Convert to platform remove callback returning void

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is (mostly) ignored
and this typically results in resource leaks. To improve here there is a
quest to make the remove callback return void. In the first step of this
quest all drivers are converted to .remove_new() which already returns
void.

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.
Signed-off-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Link: https://lore.kernel.org/r/20230303172041.2103336-34-u.kleine-koenig@pengutronix.deSigned-off-by: default avatarMark Brown <broonie@kernel.org>
parent a57b08c2
...@@ -1017,7 +1017,7 @@ static int lantiq_ssc_probe(struct platform_device *pdev) ...@@ -1017,7 +1017,7 @@ static int lantiq_ssc_probe(struct platform_device *pdev)
return err; return err;
} }
static int lantiq_ssc_remove(struct platform_device *pdev) static void lantiq_ssc_remove(struct platform_device *pdev)
{ {
struct lantiq_ssc_spi *spi = platform_get_drvdata(pdev); struct lantiq_ssc_spi *spi = platform_get_drvdata(pdev);
...@@ -1030,13 +1030,11 @@ static int lantiq_ssc_remove(struct platform_device *pdev) ...@@ -1030,13 +1030,11 @@ static int lantiq_ssc_remove(struct platform_device *pdev)
destroy_workqueue(spi->wq); destroy_workqueue(spi->wq);
clk_disable_unprepare(spi->spi_clk); clk_disable_unprepare(spi->spi_clk);
clk_put(spi->fpi_clk); clk_put(spi->fpi_clk);
return 0;
} }
static struct platform_driver lantiq_ssc_driver = { static struct platform_driver lantiq_ssc_driver = {
.probe = lantiq_ssc_probe, .probe = lantiq_ssc_probe,
.remove = lantiq_ssc_remove, .remove_new = lantiq_ssc_remove,
.driver = { .driver = {
.name = "spi-lantiq-ssc", .name = "spi-lantiq-ssc",
.of_match_table = lantiq_ssc_match, .of_match_table = lantiq_ssc_match,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment