Commit 21f0b7da authored by Nathan Huckleberry's avatar Nathan Huckleberry Committed by Jani Nikula

drm/i915: Fix return type of mode_valid function hook

All of the functions used for intel_dvo_dev_ops.mode_valid have a return
type of enum drm_mode_status, but the mode_valid field in the struct
definition has a return type of int.

The mismatched return type breaks forward edge kCFI since the underlying
function definitions do not match the function hook definition.

The return type of the mode_valid field should be changed from int to
enum drm_mode_status.
Reported-by: default avatarDan Carpenter <error27@gmail.com>
Link: https://github.com/ClangBuiltLinux/linux/issues/1703
Cc: llvm@lists.linux.dev
Signed-off-by: default avatarNathan Huckleberry <nhuck@google.com>
Reviewed-by: default avatarNathan Chancellor <nathan@kernel.org>
Reviewed-by: default avatarAndrzej Hajda <andrzej.hajda@intel.com>
Signed-off-by: default avatarJani Nikula <jani.nikula@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20220913205531.155046-1-nhuck@google.com
parent 4aaa1a98
...@@ -75,8 +75,8 @@ struct intel_dvo_dev_ops { ...@@ -75,8 +75,8 @@ struct intel_dvo_dev_ops {
* *
* \return MODE_OK if the mode is valid, or another MODE_* otherwise. * \return MODE_OK if the mode is valid, or another MODE_* otherwise.
*/ */
int (*mode_valid)(struct intel_dvo_device *dvo, enum drm_mode_status (*mode_valid)(struct intel_dvo_device *dvo,
struct drm_display_mode *mode); struct drm_display_mode *mode);
/* /*
* Callback for preparing mode changes on an output * Callback for preparing mode changes on an output
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment