Commit 222f58ac authored by Azeem Shaikh's avatar Azeem Shaikh Committed by Jens Axboe

kyber: Replace strlcpy with strscpy

strlcpy() reads the entire source buffer first.
This read may exceed the destination size limit.
This is both inefficient and can lead to linear read
overflows if a source string is not NUL-terminated [1].
In an effort to remove strlcpy() completely [2], replace
strlcpy() here with strscpy().
No return values were used, so direct replacement is safe.

[1] https://www.kernel.org/doc/html/latest/process/deprecated.html#strlcpy
[2] https://github.com/KSPP/linux/issues/89Signed-off-by: default avatarAzeem Shaikh <azeemshaikh38@gmail.com>
Reviewed-by: default avatarKees Cook <keescook@chromium.org>
Link: https://lore.kernel.org/r/20230703172159.3668349-2-azeemshaikh38@gmail.comSigned-off-by: default avatarJens Axboe <axboe@kernel.dk>
parent fdf0eaf1
...@@ -31,8 +31,8 @@ TRACE_EVENT(kyber_latency, ...@@ -31,8 +31,8 @@ TRACE_EVENT(kyber_latency,
TP_fast_assign( TP_fast_assign(
__entry->dev = dev; __entry->dev = dev;
strlcpy(__entry->domain, domain, sizeof(__entry->domain)); strscpy(__entry->domain, domain, sizeof(__entry->domain));
strlcpy(__entry->type, type, sizeof(__entry->type)); strscpy(__entry->type, type, sizeof(__entry->type));
__entry->percentile = percentile; __entry->percentile = percentile;
__entry->numerator = numerator; __entry->numerator = numerator;
__entry->denominator = denominator; __entry->denominator = denominator;
...@@ -59,7 +59,7 @@ TRACE_EVENT(kyber_adjust, ...@@ -59,7 +59,7 @@ TRACE_EVENT(kyber_adjust,
TP_fast_assign( TP_fast_assign(
__entry->dev = dev; __entry->dev = dev;
strlcpy(__entry->domain, domain, sizeof(__entry->domain)); strscpy(__entry->domain, domain, sizeof(__entry->domain));
__entry->depth = depth; __entry->depth = depth;
), ),
...@@ -81,7 +81,7 @@ TRACE_EVENT(kyber_throttled, ...@@ -81,7 +81,7 @@ TRACE_EVENT(kyber_throttled,
TP_fast_assign( TP_fast_assign(
__entry->dev = dev; __entry->dev = dev;
strlcpy(__entry->domain, domain, sizeof(__entry->domain)); strscpy(__entry->domain, domain, sizeof(__entry->domain));
), ),
TP_printk("%d,%d %s", MAJOR(__entry->dev), MINOR(__entry->dev), TP_printk("%d,%d %s", MAJOR(__entry->dev), MINOR(__entry->dev),
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment