Commit 234d6873 authored by Xin Hao's avatar Xin Hao Committed by Linus Torvalds

mm/damon: modify damon_rand() macro to static inline function

damon_rand() cannot be implemented as a macro.

Example:
	damon_rand(a++, b);

The value of 'a' will be incremented twice, This is obviously
unreasonable, So there fix it.

Link: https://lkml.kernel.org/r/110ffcd4e420c86c42b41ce2bc9f0fe6a4f32cd3.1638795127.git.xhao@linux.alibaba.com
Fixes: b9a6ac4e ("mm/damon: adaptively adjust regions")
Signed-off-by: default avatarXin Hao <xhao@linux.alibaba.com>
Reported-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Reviewed-by: default avatarSeongJae Park <sj@kernel.org>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 9b2a38d6
...@@ -19,7 +19,10 @@ ...@@ -19,7 +19,10 @@
#define DAMOS_MAX_SCORE (99) #define DAMOS_MAX_SCORE (99)
/* Get a random number in [l, r) */ /* Get a random number in [l, r) */
#define damon_rand(l, r) (l + prandom_u32_max(r - l)) static inline unsigned long damon_rand(unsigned long l, unsigned long r)
{
return l + prandom_u32_max(r - l);
}
/** /**
* struct damon_addr_range - Represents an address region of [@start, @end). * struct damon_addr_range - Represents an address region of [@start, @end).
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment