Commit 261964c6 authored by Al Viro's avatar Al Viro

isofs check for NULL ->i_op in root directory is dead code

for one thing it never happens, for another we check that inode
is a directory right after that place anyway (and we'd already
checked that reading it from disk has not failed).
Signed-off-by: default avatarAl Viro <viro@zeniv.linux.org.uk>
parent c765d479
...@@ -855,10 +855,6 @@ static int isofs_fill_super(struct super_block *s, void *data, int silent) ...@@ -855,10 +855,6 @@ static int isofs_fill_super(struct super_block *s, void *data, int silent)
} }
sbi->s_joliet_level = joliet_level; sbi->s_joliet_level = joliet_level;
/* check the root inode */
if (!inode->i_op)
goto out_bad_root;
/* Make sure the root inode is a directory */ /* Make sure the root inode is a directory */
if (!S_ISDIR(inode->i_mode)) { if (!S_ISDIR(inode->i_mode)) {
printk(KERN_WARNING printk(KERN_WARNING
...@@ -886,8 +882,6 @@ static int isofs_fill_super(struct super_block *s, void *data, int silent) ...@@ -886,8 +882,6 @@ static int isofs_fill_super(struct super_block *s, void *data, int silent)
/* /*
* Display error messages and free resources. * Display error messages and free resources.
*/ */
out_bad_root:
printk(KERN_WARNING "%s: root inode not initialized\n", __func__);
out_iput: out_iput:
iput(inode); iput(inode);
goto out_no_inode; goto out_no_inode;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment