Commit 28cbfe09 authored by Rodríguez Barbarin, José Javier's avatar Rodríguez Barbarin, José Javier Committed by Greg Kroah-Hartman

mcb: Use the actual bus passed to init and release functions

The functions mcb_bus_add_devices() and mcb_devices_unregister()
take a mcb_bus as argument that is never being used. This implies
that there is only one bus.

Do not ignore mcb_bus parameter and get the actual bus_type from
the device related to this mcb_bus.
Co-developed-by: default avatarJorge Sanjuan Garcia <jorge.sanjuangarcia@duagon.com>
Signed-off-by: default avatarJorge Sanjuan Garcia <jorge.sanjuangarcia@duagon.com>
Signed-off-by: default avatarJose Javier Rodriguez Barbarin <JoseJavier.Rodriguez@duagon.com>
Link: https://lore.kernel.org/r/20231020124324.54692-2-JoseJavier.Rodriguez@duagon.comSigned-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 0720219f
...@@ -311,7 +311,7 @@ static int __mcb_devices_unregister(struct device *dev, void *data) ...@@ -311,7 +311,7 @@ static int __mcb_devices_unregister(struct device *dev, void *data)
static void mcb_devices_unregister(struct mcb_bus *bus) static void mcb_devices_unregister(struct mcb_bus *bus)
{ {
bus_for_each_dev(&mcb_bus_type, NULL, NULL, __mcb_devices_unregister); bus_for_each_dev(bus->dev.bus, NULL, NULL, __mcb_devices_unregister);
} }
/** /**
* mcb_release_bus() - Free a @mcb_bus * mcb_release_bus() - Free a @mcb_bus
...@@ -406,7 +406,7 @@ static int __mcb_bus_add_devices(struct device *dev, void *data) ...@@ -406,7 +406,7 @@ static int __mcb_bus_add_devices(struct device *dev, void *data)
*/ */
void mcb_bus_add_devices(const struct mcb_bus *bus) void mcb_bus_add_devices(const struct mcb_bus *bus)
{ {
bus_for_each_dev(&mcb_bus_type, NULL, NULL, __mcb_bus_add_devices); bus_for_each_dev(bus->dev.bus, NULL, NULL, __mcb_bus_add_devices);
} }
EXPORT_SYMBOL_NS_GPL(mcb_bus_add_devices, MCB); EXPORT_SYMBOL_NS_GPL(mcb_bus_add_devices, MCB);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment