Commit 2c1e1b94 authored by Randy Dunlap's avatar Randy Dunlap Committed by Saeed Mahameed

net: mlx5: eliminate anonymous module_init & module_exit

Eliminate anonymous module_init() and module_exit(), which can lead to
confusion or ambiguity when reading System.map, crashes/oops/bugs,
or an initcall_debug log.

Give each of these init and exit functions unique driver-specific
names to eliminate the anonymous names.

Example 1: (System.map)
 ffffffff832fc78c t init
 ffffffff832fc79e t init
 ffffffff832fc8f8 t init

Example 2: (initcall_debug log)
 calling  init+0x0/0x12 @ 1
 initcall init+0x0/0x12 returned 0 after 15 usecs
 calling  init+0x0/0x60 @ 1
 initcall init+0x0/0x60 returned 0 after 2 usecs
 calling  init+0x0/0x9a @ 1
 initcall init+0x0/0x9a returned 0 after 74 usecs

Fixes: e126ba97 ("mlx5: Add driver for Mellanox Connect-IB adapters")
Signed-off-by: default avatarRandy Dunlap <rdunlap@infradead.org>
Cc: Eli Cohen <eli@mellanox.com>
Cc: Saeed Mahameed <saeedm@nvidia.com>
Cc: Leon Romanovsky <leon@kernel.org>
Cc: linux-rdma@vger.kernel.org
Reviewed-by: default avatarIra Weiny <ira.weiny@intel.com>
Reviewed-by: default avatarLeon Romanovsky <leonro@nvidia.com>
Signed-off-by: default avatarSaeed Mahameed <saeedm@nvidia.com>
parent 7c83d1f4
...@@ -2098,7 +2098,7 @@ static void mlx5_core_verify_params(void) ...@@ -2098,7 +2098,7 @@ static void mlx5_core_verify_params(void)
} }
} }
static int __init init(void) static int __init mlx5_init(void)
{ {
int err; int err;
...@@ -2133,7 +2133,7 @@ static int __init init(void) ...@@ -2133,7 +2133,7 @@ static int __init init(void)
return err; return err;
} }
static void __exit cleanup(void) static void __exit mlx5_cleanup(void)
{ {
mlx5e_cleanup(); mlx5e_cleanup();
mlx5_sf_driver_unregister(); mlx5_sf_driver_unregister();
...@@ -2141,5 +2141,5 @@ static void __exit cleanup(void) ...@@ -2141,5 +2141,5 @@ static void __exit cleanup(void)
mlx5_unregister_debugfs(); mlx5_unregister_debugfs();
} }
module_init(init); module_init(mlx5_init);
module_exit(cleanup); module_exit(mlx5_cleanup);
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment