Commit 2c7df744 authored by Viresh Kumar's avatar Viresh Kumar Committed by Greg Kroah-Hartman

greybus: interface: Prefix hexadecimal values with '0x'

In order to clearly specify the base of values printed using sysfs
files, prefix hexadecimal values with '0x'. Also force the minimum width
(to be printed) for hexadecimal values to their sizes.

To make it more readable make the second argument to gb_interface_attr()
a proper string.
Signed-off-by: default avatarViresh Kumar <viresh.kumar@linaro.org>
Reviewed-by: default avatarJohan Hovold <johan@hovoldconsulting.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@google.com>
parent ccb58035
...@@ -16,15 +16,15 @@ static ssize_t field##_show(struct device *dev, \ ...@@ -16,15 +16,15 @@ static ssize_t field##_show(struct device *dev, \
char *buf) \ char *buf) \
{ \ { \
struct gb_interface *intf = to_gb_interface(dev); \ struct gb_interface *intf = to_gb_interface(dev); \
return scnprintf(buf, PAGE_SIZE, "%"#type"\n", intf->field); \ return scnprintf(buf, PAGE_SIZE, type"\n", intf->field); \
} \ } \
static DEVICE_ATTR_RO(field) static DEVICE_ATTR_RO(field)
gb_interface_attr(interface_id, u); gb_interface_attr(interface_id, "%u");
gb_interface_attr(vendor_id, x); gb_interface_attr(vendor_id, "0x%08x");
gb_interface_attr(product_id, x); gb_interface_attr(product_id, "0x%08x");
gb_interface_attr(vendor_string, s); gb_interface_attr(vendor_string, "%s");
gb_interface_attr(product_string, s); gb_interface_attr(product_string, "%s");
static struct attribute *interface_attrs[] = { static struct attribute *interface_attrs[] = {
&dev_attr_interface_id.attr, &dev_attr_interface_id.attr,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment