powerpc/powernv: Don't crash if there are no OPAL consoles

Some machines might provide the console via a different mechanism
such as direct access to a UART from Linux, in which case OPAL
might not expose any console. In that case, the code would cause
a NULL dereference.
Signed-off-by: default avatarBenjamin Herrenschmidt <benh@kernel.crashing.org>
parent e0f5fa99
...@@ -380,18 +380,20 @@ static int __init opal_init(void) ...@@ -380,18 +380,20 @@ static int __init opal_init(void)
pr_warn("opal: Node not found\n"); pr_warn("opal: Node not found\n");
return -ENODEV; return -ENODEV;
} }
/* Register OPAL consoles if any ports */
if (firmware_has_feature(FW_FEATURE_OPALv2)) if (firmware_has_feature(FW_FEATURE_OPALv2))
consoles = of_find_node_by_path("/ibm,opal/consoles"); consoles = of_find_node_by_path("/ibm,opal/consoles");
else else
consoles = of_node_get(opal_node); consoles = of_node_get(opal_node);
if (consoles) {
/* Register serial ports */ for_each_child_of_node(consoles, np) {
for_each_child_of_node(consoles, np) { if (strcmp(np->name, "serial"))
if (strcmp(np->name, "serial")) continue;
continue; of_platform_device_create(np, NULL, NULL);
of_platform_device_create(np, NULL, NULL); }
of_node_put(consoles);
} }
of_node_put(consoles);
/* Find all OPAL interrupts and request them */ /* Find all OPAL interrupts and request them */
irqs = of_get_property(opal_node, "opal-interrupts", &irqlen); irqs = of_get_property(opal_node, "opal-interrupts", &irqlen);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment