Commit 3438cf17 authored by Uwe Kleine-König's avatar Uwe Kleine-König Committed by Thomas Zimmermann

drm/bridge: cdns-mhdp8546: Convert to platform remove callback returning void

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is (mostly) ignored
and this typically results in resource leaks. To improve here there is a
quest to make the remove callback return void. In the first step of this
quest all drivers are converted to .remove_new() which already returns
void.

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.
Signed-off-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: default avatarThomas Zimmermann <tzimmermann@suse.de>
Link: https://patchwork.freedesktop.org/patch/msgid/20231102165640.3307820-23-u.kleine-koenig@pengutronix.de
parent be79252e
...@@ -2596,7 +2596,7 @@ static int cdns_mhdp_probe(struct platform_device *pdev) ...@@ -2596,7 +2596,7 @@ static int cdns_mhdp_probe(struct platform_device *pdev)
return ret; return ret;
} }
static int cdns_mhdp_remove(struct platform_device *pdev) static void cdns_mhdp_remove(struct platform_device *pdev)
{ {
struct cdns_mhdp_device *mhdp = platform_get_drvdata(pdev); struct cdns_mhdp_device *mhdp = platform_get_drvdata(pdev);
unsigned long timeout = msecs_to_jiffies(100); unsigned long timeout = msecs_to_jiffies(100);
...@@ -2634,8 +2634,6 @@ static int cdns_mhdp_remove(struct platform_device *pdev) ...@@ -2634,8 +2634,6 @@ static int cdns_mhdp_remove(struct platform_device *pdev)
/* Ignoring mhdp->hdcp.check_work and mhdp->hdcp.prop_work here. */ /* Ignoring mhdp->hdcp.check_work and mhdp->hdcp.prop_work here. */
clk_disable_unprepare(mhdp->clk); clk_disable_unprepare(mhdp->clk);
return 0;
} }
static const struct of_device_id mhdp_ids[] = { static const struct of_device_id mhdp_ids[] = {
...@@ -2658,7 +2656,7 @@ static struct platform_driver mhdp_driver = { ...@@ -2658,7 +2656,7 @@ static struct platform_driver mhdp_driver = {
.of_match_table = mhdp_ids, .of_match_table = mhdp_ids,
}, },
.probe = cdns_mhdp_probe, .probe = cdns_mhdp_probe,
.remove = cdns_mhdp_remove, .remove_new = cdns_mhdp_remove,
}; };
module_platform_driver(mhdp_driver); module_platform_driver(mhdp_driver);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment