Commit 3597683c authored by Jakub Kicinski's avatar Jakub Kicinski Committed by Daniel Borkmann

tools: bpf: handle NULL return in bpf_prog_load_xattr()

bpf_object__open() can return error pointer as well as NULL.
Fix error handling in bpf_prog_load_xattr() (and indirectly
bpf_prog_load()).

Fixes: 6f6d33f3 ("bpf: selftests add sockmap tests")
Signed-off-by: default avatarJakub Kicinski <jakub.kicinski@netronome.com>
Reviewed-by: default avatarQuentin Monnet <quentin.monnet@netronome.com>
Signed-off-by: default avatarDaniel Borkmann <daniel@iogearbox.net>
parent 26aeb9da
...@@ -2035,7 +2035,7 @@ int bpf_prog_load_xattr(const struct bpf_prog_load_attr *attr, ...@@ -2035,7 +2035,7 @@ int bpf_prog_load_xattr(const struct bpf_prog_load_attr *attr,
return -EINVAL; return -EINVAL;
obj = bpf_object__open(attr->file); obj = bpf_object__open(attr->file);
if (IS_ERR(obj)) if (IS_ERR_OR_NULL(obj))
return -ENOENT; return -ENOENT;
bpf_object__for_each_program(prog, obj) { bpf_object__for_each_program(prog, obj) {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment