Commit 368e4663 authored by Christophe JAILLET's avatar Christophe JAILLET Committed by Takashi Iwai

ALSA: mixer_oss: Remove some incorrect kfree_const() usages

"assigned" and "assigned->name" are allocated in snd_mixer_oss_proc_write()
using kmalloc() and kstrdup(), so there is no point in using kfree_const()
to free these resources.

Switch to the more standard kfree() to free these resources.

This could avoid a memory leak.

Fixes: 454f5ec1 ("ALSA: mixer: oss: Constify snd_mixer_oss_assign_table definition")
Signed-off-by: default avatarChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Link: https://patch.msgid.link/63ac20f64234b7c9ea87a7fa9baf41e8255852f7.1727374631.git.christophe.jaillet@wanadoo.frSigned-off-by: default avatarTakashi Iwai <tiwai@suse.de>
parent dee47695
......@@ -901,8 +901,8 @@ static void snd_mixer_oss_slot_free(struct snd_mixer_oss_slot *chn)
struct slot *p = chn->private_data;
if (p) {
if (p->allocated && p->assigned) {
kfree_const(p->assigned->name);
kfree_const(p->assigned);
kfree(p->assigned->name);
kfree(p->assigned);
}
kfree(p);
}
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment