Commit 3cfff33a authored by Uwe Kleine-König's avatar Uwe Kleine-König Committed by Greg Kroah-Hartman

serial: sunhv: Convert to platform remove callback returning void

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is ignored (apart
from emitting a warning) and this typically results in resource leaks.

To improve here there is a quest to make the remove callback return
void. In the first step of this quest all drivers are converted to
.remove_new(), which already returns void. Eventually after all drivers
are converted, .remove_new() will be renamed to .remove().

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.
Signed-off-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Link: https://lore.kernel.org/r/20231110152927.70601-44-u.kleine-koenig@pengutronix.deSigned-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 2cf56244
...@@ -595,7 +595,7 @@ static int hv_probe(struct platform_device *op) ...@@ -595,7 +595,7 @@ static int hv_probe(struct platform_device *op)
return err; return err;
} }
static int hv_remove(struct platform_device *dev) static void hv_remove(struct platform_device *dev)
{ {
struct uart_port *port = platform_get_drvdata(dev); struct uart_port *port = platform_get_drvdata(dev);
...@@ -608,8 +608,6 @@ static int hv_remove(struct platform_device *dev) ...@@ -608,8 +608,6 @@ static int hv_remove(struct platform_device *dev)
kfree(con_write_page); kfree(con_write_page);
kfree(port); kfree(port);
sunhv_port = NULL; sunhv_port = NULL;
return 0;
} }
static const struct of_device_id hv_match[] = { static const struct of_device_id hv_match[] = {
...@@ -630,7 +628,7 @@ static struct platform_driver hv_driver = { ...@@ -630,7 +628,7 @@ static struct platform_driver hv_driver = {
.of_match_table = hv_match, .of_match_table = hv_match,
}, },
.probe = hv_probe, .probe = hv_probe,
.remove = hv_remove, .remove_new = hv_remove,
}; };
static int __init sunhv_init(void) static int __init sunhv_init(void)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment