Commit 43b6329f authored by Florian Fainelli's avatar Florian Fainelli Committed by David S. Miller

net: phy: use network device in phy_print_status

phy_print_status() currently uses dev_name(&phydev->dev) which will
usually result in printing something along those lines for Device Tree
aware drivers:

libphy: f0b60000.etherne:0a - Link is Down
libphy: f0ba0000.etherne:00 - Link is Up - 1000/Full

This is not terribly useful for network administrators or users since we
expect a network interface name to be able to correlate link events with
interfaces. Update phy_print_status() to use netdev_info() with
phydev->attached_dev which is the backing network device for our PHY
device. The leading dash is removed since netdev_info() prefixes the
messages with "<interface>: " already.
Signed-off-by: default avatarFlorian Fainelli <f.fainelli@gmail.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 0e4767aa
...@@ -45,12 +45,11 @@ ...@@ -45,12 +45,11 @@
void phy_print_status(struct phy_device *phydev) void phy_print_status(struct phy_device *phydev)
{ {
if (phydev->link) { if (phydev->link) {
pr_info("%s - Link is Up - %d/%s\n", netdev_info(phydev->attached_dev, "Link is Up - %d/%s\n",
dev_name(&phydev->dev),
phydev->speed, phydev->speed,
DUPLEX_FULL == phydev->duplex ? "Full" : "Half"); DUPLEX_FULL == phydev->duplex ? "Full" : "Half");
} else { } else {
pr_info("%s - Link is Down\n", dev_name(&phydev->dev)); netdev_info(phydev->attached_dev, "Link is Down\n");
} }
} }
EXPORT_SYMBOL(phy_print_status); EXPORT_SYMBOL(phy_print_status);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment