Commit 4e2e65e2 authored by liuyacan's avatar liuyacan Committed by David S. Miller

net/smc: sync err code when tcp connection was refused

In the current implementation, when TCP initiates a connection
to an unavailable [ip,port], ECONNREFUSED will be stored in the
TCP socket, but SMC will not. However, some apps (like curl) use
getsockopt(,,SO_ERROR,,) to get the error information, which makes
them miss the error message and behave strangely.

Fixes: 50717a37 ("net/smc: nonblocking connect rework")
Signed-off-by: default avatarliuyacan <liuyacan@corp.netease.com>
Reviewed-by: default avatarTony Lu <tonylu@linux.alibaba.com>
Acked-by: default avatarKarsten Graul <kgraul@linux.ibm.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent e85f8a9f
...@@ -1475,6 +1475,8 @@ static void smc_connect_work(struct work_struct *work) ...@@ -1475,6 +1475,8 @@ static void smc_connect_work(struct work_struct *work)
smc->sk.sk_state = SMC_CLOSED; smc->sk.sk_state = SMC_CLOSED;
if (rc == -EPIPE || rc == -EAGAIN) if (rc == -EPIPE || rc == -EAGAIN)
smc->sk.sk_err = EPIPE; smc->sk.sk_err = EPIPE;
else if (rc == -ECONNREFUSED)
smc->sk.sk_err = ECONNREFUSED;
else if (signal_pending(current)) else if (signal_pending(current))
smc->sk.sk_err = -sock_intr_errno(timeo); smc->sk.sk_err = -sock_intr_errno(timeo);
sock_put(&smc->sk); /* passive closing */ sock_put(&smc->sk); /* passive closing */
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment