Commit 4ee77214 authored by Ajit Khaparde's avatar Ajit Khaparde Committed by David S. Miller

be2net: fixes in ethtool selftest

> add missing separator between items in ethtool self_test array
> fix reporting of test resluts when link is down and
  when selftest command fails.

From: Suresh R <suresh.reddy@emulex.com>
Signed-off-by: default avatarAjit Khaparde <ajit.khaparde@emulex.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent f6c4bf3e
...@@ -127,7 +127,7 @@ static const char et_self_tests[][ETH_GSTRING_LEN] = { ...@@ -127,7 +127,7 @@ static const char et_self_tests[][ETH_GSTRING_LEN] = {
"MAC Loopback test", "MAC Loopback test",
"PHY Loopback test", "PHY Loopback test",
"External Loopback test", "External Loopback test",
"DDR DMA test" "DDR DMA test",
"Link test" "Link test"
}; };
...@@ -642,7 +642,8 @@ be_self_test(struct net_device *netdev, struct ethtool_test *test, u64 *data) ...@@ -642,7 +642,8 @@ be_self_test(struct net_device *netdev, struct ethtool_test *test, u64 *data)
&qos_link_speed) != 0) { &qos_link_speed) != 0) {
test->flags |= ETH_TEST_FL_FAILED; test->flags |= ETH_TEST_FL_FAILED;
data[4] = -1; data[4] = -1;
} else if (mac_speed) { } else if (!mac_speed) {
test->flags |= ETH_TEST_FL_FAILED;
data[4] = 1; data[4] = 1;
} }
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment