Commit 5626e0bf authored by Johan Hovold's avatar Johan Hovold Committed by Greg Kroah-Hartman

greybus: interface: clean up error messages

Drop redundant __func__ and add missing errno values.
Signed-off-by: default avatarJohan Hovold <johan@hovoldconsulting.com>
Reviewed-by: default avatarViresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@google.com>
parent ab66dd78
...@@ -179,8 +179,7 @@ int gb_interface_init(struct gb_interface *intf, u8 device_id) ...@@ -179,8 +179,7 @@ int gb_interface_init(struct gb_interface *intf, u8 device_id)
/* Get manifest size using control protocol on CPort */ /* Get manifest size using control protocol on CPort */
size = gb_control_get_manifest_size_operation(intf); size = gb_control_get_manifest_size_operation(intf);
if (size <= 0) { if (size <= 0) {
dev_err(&intf->dev, "%s: Failed to get manifest size (%d)\n", dev_err(&intf->dev, "failed to get manifest size: %d\n", size);
__func__, size);
if (size) if (size)
return size; return size;
else else
...@@ -194,7 +193,7 @@ int gb_interface_init(struct gb_interface *intf, u8 device_id) ...@@ -194,7 +193,7 @@ int gb_interface_init(struct gb_interface *intf, u8 device_id)
/* Get manifest using control protocol on CPort */ /* Get manifest using control protocol on CPort */
ret = gb_control_get_manifest_operation(intf, manifest, size); ret = gb_control_get_manifest_operation(intf, manifest, size);
if (ret) { if (ret) {
dev_err(&intf->dev, "%s: Failed to get manifest\n", __func__); dev_err(&intf->dev, "failed to get manifest: %d\n", ret);
goto free_manifest; goto free_manifest;
} }
...@@ -203,7 +202,7 @@ int gb_interface_init(struct gb_interface *intf, u8 device_id) ...@@ -203,7 +202,7 @@ int gb_interface_init(struct gb_interface *intf, u8 device_id)
* what's in it. * what's in it.
*/ */
if (!gb_manifest_parse(intf, manifest, size)) { if (!gb_manifest_parse(intf, manifest, size)) {
dev_err(&intf->dev, "%s: Failed to parse manifest\n", __func__); dev_err(&intf->dev, "failed to parse manifest\n");
ret = -EINVAL; ret = -EINVAL;
goto free_manifest; goto free_manifest;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment