Commit 5a6e0cf7 authored by Solomon Peachy's avatar Solomon Peachy Committed by John W. Linville

cw1200: Fix spurious BUG_ON() trigger when starting AP mode.

There's an underlying race condition with the unjoin_work() call that is
sometimes triggered depending on scheduling order and the phase of the
moon.  This doesn't fix the race condition, but it does remove the
ill-advised BUG_ON() call in an easily-recoverable situation.
Signed-off-by: default avatarSolomon Peachy <pizza@shaftnet.org>
Signed-off-by: default avatarJohn W. Linville <linville@tuxdriver.com>
parent 89b59bcd
...@@ -1406,11 +1406,8 @@ static void cw1200_do_unjoin(struct cw1200_common *priv) ...@@ -1406,11 +1406,8 @@ static void cw1200_do_unjoin(struct cw1200_common *priv)
if (!priv->join_status) if (!priv->join_status)
goto done; goto done;
if (priv->join_status > CW1200_JOIN_STATUS_IBSS) { if (priv->join_status == CW1200_JOIN_STATUS_AP)
wiphy_err(priv->hw->wiphy, "Unexpected: join status: %d\n", goto done;
priv->join_status);
BUG_ON(1);
}
cancel_work_sync(&priv->update_filtering_work); cancel_work_sync(&priv->update_filtering_work);
cancel_work_sync(&priv->set_beacon_wakeup_period_work); cancel_work_sync(&priv->set_beacon_wakeup_period_work);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment