Commit 63a60036 authored by Long Li's avatar Long Li Committed by Luis Henriques

storvsc: ring buffer failures may result in I/O freeze

commit e86fb5e8 upstream.

When ring buffer returns an error indicating retry, storvsc may not
return a proper error code to SCSI when bounce buffer is not used.
This has introduced I/O freeze on RAID running atop storvsc devices.
This patch fixes it by always returning a proper error code.
Signed-off-by: default avatarLong Li <longli@microsoft.com>
Reviewed-by: default avatarK. Y. Srinivasan <kys@microsoft.com>
Signed-off-by: default avatarChristoph Hellwig <hch@lst.de>
Signed-off-by: default avatarLuis Henriques <luis.henriques@canonical.com>
parent e144f664
...@@ -1690,13 +1690,12 @@ static int storvsc_queuecommand(struct Scsi_Host *host, struct scsi_cmnd *scmnd) ...@@ -1690,13 +1690,12 @@ static int storvsc_queuecommand(struct Scsi_Host *host, struct scsi_cmnd *scmnd)
if (ret == -EAGAIN) { if (ret == -EAGAIN) {
/* no more space */ /* no more space */
if (cmd_request->bounce_sgl_count) { if (cmd_request->bounce_sgl_count)
destroy_bounce_buffer(cmd_request->bounce_sgl, destroy_bounce_buffer(cmd_request->bounce_sgl,
cmd_request->bounce_sgl_count); cmd_request->bounce_sgl_count);
ret = SCSI_MLQUEUE_DEVICE_BUSY; ret = SCSI_MLQUEUE_DEVICE_BUSY;
goto queue_error; goto queue_error;
}
} }
return 0; return 0;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment