Commit 675faf5a authored by KhaiWenTan's avatar KhaiWenTan Committed by Paolo Abeni

net: stmmac: Fix zero-division error when disabling tc cbs

The commit b8c43360 ("net: stmmac: No need to calculate speed divider
when offload is disabled") allows the "port_transmit_rate_kbps" to be
set to a value of 0, which is then passed to the "div_s64" function when
tc-cbs is disabled. This leads to a zero-division error.

When tc-cbs is disabled, the idleslope, sendslope, and credit values the
credit values are not required to be configured. Therefore, adding a return
statement after setting the txQ mode to DCB when tc-cbs is disabled would
prevent a zero-division error.

Fixes: b8c43360 ("net: stmmac: No need to calculate speed divider when offload is disabled")
Cc: <stable@vger.kernel.org>
Co-developed-by: default avatarChoong Yong Liang <yong.liang.choong@linux.intel.com>
Signed-off-by: default avatarChoong Yong Liang <yong.liang.choong@linux.intel.com>
Signed-off-by: default avatarKhaiWenTan <khai.wen.tan@linux.intel.com>
Reviewed-by: default avatarSimon Horman <horms@kernel.org>
Link: https://patch.msgid.link/20240918061422.1589662-1-khai.wen.tan@linux.intel.comSigned-off-by: default avatarPaolo Abeni <pabeni@redhat.com>
parent ced8e8b8
......@@ -386,6 +386,7 @@ static int tc_setup_cbs(struct stmmac_priv *priv,
return ret;
priv->plat->tx_queues_cfg[queue].mode_to_use = MTL_QUEUE_DCB;
return 0;
}
/* Final adjustments for HW */
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment