Commit 67fcd5d2 authored by Uwe Kleine-König's avatar Uwe Kleine-König Committed by Neil Armstrong

drm/bridge: ti-tfp410: Convert to platform remove callback returning void

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is (mostly) ignored
and this typically results in resource leaks. To improve here there is a
quest to make the remove callback return void. In the first step of this
quest all drivers are converted to .remove_new() which already returns
void.

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.
Signed-off-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Reviewed-by: default avatarLaurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Signed-off-by: default avatarNeil Armstrong <neil.armstrong@linaro.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20230318190804.234610-20-u.kleine-koenig@pengutronix.de
parent 5e3ea764
...@@ -355,11 +355,9 @@ static int tfp410_probe(struct platform_device *pdev) ...@@ -355,11 +355,9 @@ static int tfp410_probe(struct platform_device *pdev)
return tfp410_init(&pdev->dev, false); return tfp410_init(&pdev->dev, false);
} }
static int tfp410_remove(struct platform_device *pdev) static void tfp410_remove(struct platform_device *pdev)
{ {
tfp410_fini(&pdev->dev); tfp410_fini(&pdev->dev);
return 0;
} }
static const struct of_device_id tfp410_match[] = { static const struct of_device_id tfp410_match[] = {
...@@ -370,7 +368,7 @@ MODULE_DEVICE_TABLE(of, tfp410_match); ...@@ -370,7 +368,7 @@ MODULE_DEVICE_TABLE(of, tfp410_match);
static struct platform_driver tfp410_platform_driver = { static struct platform_driver tfp410_platform_driver = {
.probe = tfp410_probe, .probe = tfp410_probe,
.remove = tfp410_remove, .remove_new = tfp410_remove,
.driver = { .driver = {
.name = "tfp410-bridge", .name = "tfp410-bridge",
.of_match_table = tfp410_match, .of_match_table = tfp410_match,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment