Commit 6c0a15a3 authored by Dan Carpenter's avatar Dan Carpenter Committed by Miquel Raynal

mtd: parsers: tplink_safeloader: fix uninitialized variable bug

On 64 bit systems, the highest 32 bits of the "offset" variable are
not initialized.  Also the existing code is not endian safe (it will
fail on big endian systems).  Change the type of "offset" to a u32.

Fixes: aec4d5f5ffd0 ("mtd: parsers: add TP-Link SafeLoader partitions table parser")
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Acked-by: default avatarRafał Miłecki <rafal@milecki.pl>
Signed-off-by: default avatarMiquel Raynal <miquel.raynal@bootlin.com>
Link: https://lore.kernel.org/linux-mtd/Y1gCALFWXYYwqV1P@kili
parent 00a35880
...@@ -23,8 +23,8 @@ static void *mtd_parser_tplink_safeloader_read_table(struct mtd_info *mtd) ...@@ -23,8 +23,8 @@ static void *mtd_parser_tplink_safeloader_read_table(struct mtd_info *mtd)
struct safeloader_cmn_header hdr; struct safeloader_cmn_header hdr;
struct device_node *np; struct device_node *np;
size_t bytes_read; size_t bytes_read;
size_t offset;
size_t size; size_t size;
u32 offset;
char *buf; char *buf;
int err; int err;
...@@ -34,14 +34,14 @@ static void *mtd_parser_tplink_safeloader_read_table(struct mtd_info *mtd) ...@@ -34,14 +34,14 @@ static void *mtd_parser_tplink_safeloader_read_table(struct mtd_info *mtd)
else else
np = of_get_child_by_name(np, "partitions"); np = of_get_child_by_name(np, "partitions");
if (of_property_read_u32(np, "partitions-table-offset", (u32 *)&offset)) { if (of_property_read_u32(np, "partitions-table-offset", &offset)) {
pr_err("Failed to get partitions table offset\n"); pr_err("Failed to get partitions table offset\n");
goto err_put; goto err_put;
} }
err = mtd_read(mtd, offset, sizeof(hdr), &bytes_read, (uint8_t *)&hdr); err = mtd_read(mtd, offset, sizeof(hdr), &bytes_read, (uint8_t *)&hdr);
if (err && !mtd_is_bitflip(err)) { if (err && !mtd_is_bitflip(err)) {
pr_err("Failed to read from %s at 0x%zx\n", mtd->name, offset); pr_err("Failed to read from %s at 0x%x\n", mtd->name, offset);
goto err_put; goto err_put;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment