Commit 73e1c093 authored by Andreas Larsson's avatar Andreas Larsson Committed by Felipe Balbi

usb: gadget: gr_udc: Use of_property_read_u32_index to access arrays

Use an appropriate accessor function for property arrays to make the code nicer
and make the code correct if it would ever run on little endian architectures.
Suggested by Mark Rutland.
Signed-off-by: default avatarAndreas Larsson <andreas@gaisler.com>
Signed-off-by: default avatarFelipe Balbi <balbi@ti.com>
parent 196800da
...@@ -2020,9 +2020,7 @@ static int gr_udc_init(struct gr_udc *dev) ...@@ -2020,9 +2020,7 @@ static int gr_udc_init(struct gr_udc *dev)
u32 dmactrl_val; u32 dmactrl_val;
int i; int i;
int ret = 0; int ret = 0;
u32 *bufsizes;
u32 bufsize; u32 bufsize;
int len;
gr_set_address(dev, 0); gr_set_address(dev, 0);
...@@ -2033,19 +2031,17 @@ static int gr_udc_init(struct gr_udc *dev) ...@@ -2033,19 +2031,17 @@ static int gr_udc_init(struct gr_udc *dev)
INIT_LIST_HEAD(&dev->ep_list); INIT_LIST_HEAD(&dev->ep_list);
gr_set_ep0state(dev, GR_EP0_DISCONNECT); gr_set_ep0state(dev, GR_EP0_DISCONNECT);
bufsizes = (u32 *)of_get_property(np, "epobufsizes", &len);
len /= sizeof(u32);
for (i = 0; i < dev->nepo; i++) { for (i = 0; i < dev->nepo; i++) {
bufsize = (bufsizes && i < len) ? bufsizes[i] : 1024; if (of_property_read_u32_index(np, "epobufsizes", i, &bufsize))
bufsize = 1024;
ret = gr_ep_init(dev, i, 0, bufsize); ret = gr_ep_init(dev, i, 0, bufsize);
if (ret) if (ret)
return ret; return ret;
} }
bufsizes = (u32 *)of_get_property(np, "epibufsizes", &len);
len /= sizeof(u32);
for (i = 0; i < dev->nepi; i++) { for (i = 0; i < dev->nepi; i++) {
bufsize = (bufsizes && i < len) ? bufsizes[i] : 1024; if (of_property_read_u32_index(np, "epibufsizes", i, &bufsize))
bufsize = 1024;
ret = gr_ep_init(dev, i, 1, bufsize); ret = gr_ep_init(dev, i, 1, bufsize);
if (ret) if (ret)
return ret; return ret;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment