Commit 76e4290c authored by Julia Lawall's avatar Julia Lawall Committed by Greg Kroah-Hartman

staging: lustre: lmv: Use !x to check for kzalloc failure

!x is more normal for kzalloc failure in the kernel.

The semantic patch that makes this change is as follows:
(http://coccinelle.lip6.fr/)

// <smpl>
@@
expression x;
statement S1, S2;
@@

x = kzalloc(...);
if (
- x == NULL
+ !x
 ) S1 else S2
// </smpl>
Signed-off-by: default avatarJulia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 94e67761
...@@ -100,7 +100,7 @@ static int lmv_intent_remote(struct obd_export *exp, void *lmm, ...@@ -100,7 +100,7 @@ static int lmv_intent_remote(struct obd_export *exp, void *lmm,
} }
op_data = kzalloc(sizeof(*op_data), GFP_NOFS); op_data = kzalloc(sizeof(*op_data), GFP_NOFS);
if (op_data == NULL) { if (!op_data) {
rc = -ENOMEM; rc = -ENOMEM;
goto out; goto out;
} }
......
...@@ -716,7 +716,7 @@ static int lmv_fid2path(struct obd_export *exp, int len, void *karg, void *uarg) ...@@ -716,7 +716,7 @@ static int lmv_fid2path(struct obd_export *exp, int len, void *karg, void *uarg)
if (remote_gf == NULL) { if (remote_gf == NULL) {
remote_gf_size = sizeof(*remote_gf) + PATH_MAX; remote_gf_size = sizeof(*remote_gf) + PATH_MAX;
remote_gf = kzalloc(remote_gf_size, GFP_NOFS); remote_gf = kzalloc(remote_gf_size, GFP_NOFS);
if (remote_gf == NULL) { if (!remote_gf) {
rc = -ENOMEM; rc = -ENOMEM;
goto out_fid2path; goto out_fid2path;
} }
...@@ -1398,7 +1398,7 @@ static int lmv_statfs(const struct lu_env *env, struct obd_export *exp, ...@@ -1398,7 +1398,7 @@ static int lmv_statfs(const struct lu_env *env, struct obd_export *exp,
return rc; return rc;
temp = kzalloc(sizeof(*temp), GFP_NOFS); temp = kzalloc(sizeof(*temp), GFP_NOFS);
if (temp == NULL) if (!temp)
return -ENOMEM; return -ENOMEM;
for (i = 0; i < lmv->desc.ld_tgt_count; i++) { for (i = 0; i < lmv->desc.ld_tgt_count; i++) {
...@@ -1730,7 +1730,7 @@ lmv_enqueue_remote(struct obd_export *exp, struct ldlm_enqueue_info *einfo, ...@@ -1730,7 +1730,7 @@ lmv_enqueue_remote(struct obd_export *exp, struct ldlm_enqueue_info *einfo,
} }
rdata = kzalloc(sizeof(*rdata), GFP_NOFS); rdata = kzalloc(sizeof(*rdata), GFP_NOFS);
if (rdata == NULL) { if (!rdata) {
rc = -ENOMEM; rc = -ENOMEM;
goto out; goto out;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment