Commit 7b7dfe48 authored by Duoming Zhou's avatar Duoming Zhou Committed by Greg Kroah-Hartman

tty: n_gsm: fix sleep-in-atomic-context bug in gsm_control_send

The function gsm_dlci_t1() is a timer handler that runs in an
atomic context, but it calls "kzalloc(..., GFP_KERNEL)" that
may sleep. As a result, the sleep-in-atomic-context bug will
happen. The process is shown below:

gsm_dlci_t1()
 gsm_dlci_open()
  gsm_modem_update()
   gsm_modem_upd_via_msc()
    gsm_control_send()
     kzalloc(sizeof(.., GFP_KERNEL) //may sleep

This patch changes the gfp_t parameter of kzalloc() from GFP_KERNEL to
GFP_ATOMIC in order to mitigate the bug.

Fixes: e1eaea46 ("tty: n_gsm line discipline")
Signed-off-by: default avatarDuoming Zhou <duoming@zju.edu.cn>
Link: https://lore.kernel.org/r/20221002040709.27849-1-duoming@zju.edu.cnSigned-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 15743ae5
...@@ -1711,7 +1711,7 @@ static struct gsm_control *gsm_control_send(struct gsm_mux *gsm, ...@@ -1711,7 +1711,7 @@ static struct gsm_control *gsm_control_send(struct gsm_mux *gsm,
unsigned int command, u8 *data, int clen) unsigned int command, u8 *data, int clen)
{ {
struct gsm_control *ctrl = kzalloc(sizeof(struct gsm_control), struct gsm_control *ctrl = kzalloc(sizeof(struct gsm_control),
GFP_KERNEL); GFP_ATOMIC);
unsigned long flags; unsigned long flags;
if (ctrl == NULL) if (ctrl == NULL)
return NULL; return NULL;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment