Commit 7db8263a authored by Yang Li's avatar Yang Li Committed by David S. Miller

ethtool: Fix an error code in cxgb2.c

When adapter->registered_device_map is NULL, the value of err is
uncertain, we set err to -EINVAL to avoid ambiguity.

Clean up smatch warning:
drivers/net/ethernet/chelsio/cxgb/cxgb2.c:1114 init_one() warn: missing
error code 'err'
Reported-by: default avatarAbaci Robot <abaci@linux.alibaba.com>
Signed-off-by: default avatarYang Li <yang.lee@linux.alibaba.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 9ddbc2a0
...@@ -1111,6 +1111,7 @@ static int init_one(struct pci_dev *pdev, const struct pci_device_id *ent) ...@@ -1111,6 +1111,7 @@ static int init_one(struct pci_dev *pdev, const struct pci_device_id *ent)
if (!adapter->registered_device_map) { if (!adapter->registered_device_map) {
pr_err("%s: could not register any net devices\n", pr_err("%s: could not register any net devices\n",
pci_name(pdev)); pci_name(pdev));
err = -EINVAL;
goto out_release_adapter_res; goto out_release_adapter_res;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment