Commit 82a2c0cc authored by Uwe Kleine-König's avatar Uwe Kleine-König Committed by Douglas Anderson

drm/hisilicon: Convert to platform remove callback returning void

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is (mostly) ignored
and this typically results in resource leaks. To improve here there is a
quest to make the remove callback return void. In the first step of this
quest all drivers are converted to .remove_new() which already returns
void.

Trivially convert the hisilicon drm drivers from always returning zero
in the remove callback to the void returning variant.
Signed-off-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Reviewed-by: default avatarLaurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: default avatarDouglas Anderson <dianders@chromium.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20230507162616.1368908-21-u.kleine-koenig@pengutronix.de
parent c3b28b29
...@@ -874,14 +874,12 @@ static int dsi_probe(struct platform_device *pdev) ...@@ -874,14 +874,12 @@ static int dsi_probe(struct platform_device *pdev)
return 0; return 0;
} }
static int dsi_remove(struct platform_device *pdev) static void dsi_remove(struct platform_device *pdev)
{ {
struct dsi_data *data = platform_get_drvdata(pdev); struct dsi_data *data = platform_get_drvdata(pdev);
struct dw_dsi *dsi = &data->dsi; struct dw_dsi *dsi = &data->dsi;
mipi_dsi_host_unregister(&dsi->host); mipi_dsi_host_unregister(&dsi->host);
return 0;
} }
static const struct of_device_id dsi_of_match[] = { static const struct of_device_id dsi_of_match[] = {
...@@ -892,7 +890,7 @@ MODULE_DEVICE_TABLE(of, dsi_of_match); ...@@ -892,7 +890,7 @@ MODULE_DEVICE_TABLE(of, dsi_of_match);
static struct platform_driver dsi_driver = { static struct platform_driver dsi_driver = {
.probe = dsi_probe, .probe = dsi_probe,
.remove = dsi_remove, .remove_new = dsi_remove,
.driver = { .driver = {
.name = "dw-dsi", .name = "dw-dsi",
.of_match_table = dsi_of_match, .of_match_table = dsi_of_match,
......
...@@ -279,10 +279,9 @@ static int kirin_drm_platform_probe(struct platform_device *pdev) ...@@ -279,10 +279,9 @@ static int kirin_drm_platform_probe(struct platform_device *pdev)
return component_master_add_with_match(dev, &kirin_drm_ops, match); return component_master_add_with_match(dev, &kirin_drm_ops, match);
} }
static int kirin_drm_platform_remove(struct platform_device *pdev) static void kirin_drm_platform_remove(struct platform_device *pdev)
{ {
component_master_del(&pdev->dev, &kirin_drm_ops); component_master_del(&pdev->dev, &kirin_drm_ops);
return 0;
} }
static const struct of_device_id kirin_drm_dt_ids[] = { static const struct of_device_id kirin_drm_dt_ids[] = {
...@@ -295,7 +294,7 @@ MODULE_DEVICE_TABLE(of, kirin_drm_dt_ids); ...@@ -295,7 +294,7 @@ MODULE_DEVICE_TABLE(of, kirin_drm_dt_ids);
static struct platform_driver kirin_drm_platform_driver = { static struct platform_driver kirin_drm_platform_driver = {
.probe = kirin_drm_platform_probe, .probe = kirin_drm_platform_probe,
.remove = kirin_drm_platform_remove, .remove_new = kirin_drm_platform_remove,
.driver = { .driver = {
.name = "kirin-drm", .name = "kirin-drm",
.of_match_table = kirin_drm_dt_ids, .of_match_table = kirin_drm_dt_ids,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment