Commit 84e6da7a authored by Uwe Kleine-König's avatar Uwe Kleine-König Committed by Douglas Anderson

drm/tiny: Convert to platform remove callback returning void

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is (mostly) ignored
and this typically results in resource leaks. To improve here there is a
quest to make the remove callback return void. In the first step of this
quest all drivers are converted to .remove_new() which already returns
void.

Trivially convert the tiny drm drivers from always returning zero in the
remove callback to the void returning variant.
Signed-off-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: default avatarDouglas Anderson <dianders@chromium.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20230507162616.1368908-50-u.kleine-koenig@pengutronix.de
parent 34cdd1f6
...@@ -1369,13 +1369,11 @@ static int ofdrm_probe(struct platform_device *pdev) ...@@ -1369,13 +1369,11 @@ static int ofdrm_probe(struct platform_device *pdev)
return 0; return 0;
} }
static int ofdrm_remove(struct platform_device *pdev) static void ofdrm_remove(struct platform_device *pdev)
{ {
struct drm_device *dev = platform_get_drvdata(pdev); struct drm_device *dev = platform_get_drvdata(pdev);
drm_dev_unplug(dev); drm_dev_unplug(dev);
return 0;
} }
static const struct of_device_id ofdrm_of_match_display[] = { static const struct of_device_id ofdrm_of_match_display[] = {
...@@ -1390,7 +1388,7 @@ static struct platform_driver ofdrm_platform_driver = { ...@@ -1390,7 +1388,7 @@ static struct platform_driver ofdrm_platform_driver = {
.of_match_table = ofdrm_of_match_display, .of_match_table = ofdrm_of_match_display,
}, },
.probe = ofdrm_probe, .probe = ofdrm_probe,
.remove = ofdrm_remove, .remove_new = ofdrm_remove,
}; };
module_platform_driver(ofdrm_platform_driver); module_platform_driver(ofdrm_platform_driver);
......
...@@ -888,14 +888,12 @@ static int simpledrm_probe(struct platform_device *pdev) ...@@ -888,14 +888,12 @@ static int simpledrm_probe(struct platform_device *pdev)
return 0; return 0;
} }
static int simpledrm_remove(struct platform_device *pdev) static void simpledrm_remove(struct platform_device *pdev)
{ {
struct simpledrm_device *sdev = platform_get_drvdata(pdev); struct simpledrm_device *sdev = platform_get_drvdata(pdev);
struct drm_device *dev = &sdev->dev; struct drm_device *dev = &sdev->dev;
drm_dev_unplug(dev); drm_dev_unplug(dev);
return 0;
} }
static const struct of_device_id simpledrm_of_match_table[] = { static const struct of_device_id simpledrm_of_match_table[] = {
...@@ -910,7 +908,7 @@ static struct platform_driver simpledrm_platform_driver = { ...@@ -910,7 +908,7 @@ static struct platform_driver simpledrm_platform_driver = {
.of_match_table = simpledrm_of_match_table, .of_match_table = simpledrm_of_match_table,
}, },
.probe = simpledrm_probe, .probe = simpledrm_probe,
.remove = simpledrm_remove, .remove_new = simpledrm_remove,
}; };
module_platform_driver(simpledrm_platform_driver); module_platform_driver(simpledrm_platform_driver);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment