Commit 87ade72a authored by Cesar Eduardo Barros's avatar Cesar Eduardo Barros Committed by Linus Torvalds

sys_swapon: simplify error flow in claim_swapfile()

Since there is no cleanup to do, there is no reason to jump to a label.
Return directly instead.
Signed-off-by: default avatarCesar Eduardo Barros <cesarb@cesarb.net>
Tested-by: default avatarEric B Munson <emunson@mgebm.net>
Acked-by: default avatarEric B Munson <emunson@mgebm.net>
Reviewed-by: default avatarKAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Cc: Hugh Dickins <hughd@google.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 4d0e1e10
...@@ -1900,30 +1900,22 @@ static int claim_swapfile(struct swap_info_struct *p, struct inode *inode) ...@@ -1900,30 +1900,22 @@ static int claim_swapfile(struct swap_info_struct *p, struct inode *inode)
sys_swapon); sys_swapon);
if (error < 0) { if (error < 0) {
p->bdev = NULL; p->bdev = NULL;
error = -EINVAL; return -EINVAL;
goto bad_swap;
} }
p->old_block_size = block_size(p->bdev); p->old_block_size = block_size(p->bdev);
error = set_blocksize(p->bdev, PAGE_SIZE); error = set_blocksize(p->bdev, PAGE_SIZE);
if (error < 0) if (error < 0)
goto bad_swap; return error;
p->flags |= SWP_BLKDEV; p->flags |= SWP_BLKDEV;
} else if (S_ISREG(inode->i_mode)) { } else if (S_ISREG(inode->i_mode)) {
p->bdev = inode->i_sb->s_bdev; p->bdev = inode->i_sb->s_bdev;
mutex_lock(&inode->i_mutex); mutex_lock(&inode->i_mutex);
if (IS_SWAPFILE(inode)) { if (IS_SWAPFILE(inode))
error = -EBUSY; return -EBUSY;
goto bad_swap; } else
} return -EINVAL;
} else {
error = -EINVAL;
goto bad_swap;
}
return 0; return 0;
bad_swap:
return error;
} }
SYSCALL_DEFINE2(swapon, const char __user *, specialfile, int, swap_flags) SYSCALL_DEFINE2(swapon, const char __user *, specialfile, int, swap_flags)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment