Commit 894d7508 authored by Marc Kleine-Budde's avatar Marc Kleine-Budde Committed by David S. Miller

net: netdev_queue: netdev_txq_completed_mb(): fix wake condition

netif_txq_try_stop() uses "get_desc >= start_thrs" as the check for
the call to netif_tx_start_queue().

Use ">=" i netdev_txq_completed_mb(), too.

Fixes: c91c46de ("net: provide macros for commonly copied lockless queue stop/wake code")
Signed-off-by: default avatarMarc Kleine-Budde <mkl@pengutronix.de>
Acked-by: default avatarJakub Kicinski <kuba@kernel.org>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 9181d6f8
...@@ -128,7 +128,7 @@ netdev_txq_completed_mb(struct netdev_queue *dev_queue, ...@@ -128,7 +128,7 @@ netdev_txq_completed_mb(struct netdev_queue *dev_queue,
netdev_txq_completed_mb(txq, pkts, bytes); \ netdev_txq_completed_mb(txq, pkts, bytes); \
\ \
_res = -1; \ _res = -1; \
if (pkts && likely(get_desc > start_thrs)) { \ if (pkts && likely(get_desc >= start_thrs)) { \
_res = 1; \ _res = 1; \
if (unlikely(netif_tx_queue_stopped(txq)) && \ if (unlikely(netif_tx_queue_stopped(txq)) && \
!(down_cond)) { \ !(down_cond)) { \
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment