Commit 8a97d4c1 authored by Guennadi Liakhovetski's avatar Guennadi Liakhovetski Committed by Mauro Carvalho Chehab

[media] soc-camera: fix repeated regulator requesting

Currently devm_regulator_bulk_get() is called by soc-camera during host
driver probing, but regulators are attached to the camera platform
device, that is staying, independent whether the host probed successfully
or not. This can lead to repeated regulator requesting, if the host
driver is re-probed. Move the call to platform device probing to avoid
this.
Signed-off-by: default avatarGuennadi Liakhovetski <g.liakhovetski@gmx.de>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@redhat.com>
parent 7d051b35
...@@ -1149,11 +1149,6 @@ static int soc_camera_probe(struct soc_camera_device *icd) ...@@ -1149,11 +1149,6 @@ static int soc_camera_probe(struct soc_camera_device *icd)
if (ret < 0) if (ret < 0)
return ret; return ret;
ret = devm_regulator_bulk_get(icd->pdev, icl->num_regulators,
icl->regulators);
if (ret < 0)
goto ereg;
/* The camera could have been already on, try to reset */ /* The camera could have been already on, try to reset */
if (icl->reset) if (icl->reset)
icl->reset(icd->pdev); icl->reset(icd->pdev);
...@@ -1260,7 +1255,6 @@ static int soc_camera_probe(struct soc_camera_device *icd) ...@@ -1260,7 +1255,6 @@ static int soc_camera_probe(struct soc_camera_device *icd)
ici->ops->remove(icd); ici->ops->remove(icd);
mutex_unlock(&ici->host_lock); mutex_unlock(&ici->host_lock);
eadd: eadd:
ereg:
v4l2_ctrl_handler_free(&icd->ctrl_handler); v4l2_ctrl_handler_free(&icd->ctrl_handler);
return ret; return ret;
} }
...@@ -1549,6 +1543,7 @@ static int __devinit soc_camera_pdrv_probe(struct platform_device *pdev) ...@@ -1549,6 +1543,7 @@ static int __devinit soc_camera_pdrv_probe(struct platform_device *pdev)
{ {
struct soc_camera_link *icl = pdev->dev.platform_data; struct soc_camera_link *icl = pdev->dev.platform_data;
struct soc_camera_device *icd; struct soc_camera_device *icd;
int ret;
if (!icl) if (!icl)
return -EINVAL; return -EINVAL;
...@@ -1557,6 +1552,11 @@ static int __devinit soc_camera_pdrv_probe(struct platform_device *pdev) ...@@ -1557,6 +1552,11 @@ static int __devinit soc_camera_pdrv_probe(struct platform_device *pdev)
if (!icd) if (!icd)
return -ENOMEM; return -ENOMEM;
ret = devm_regulator_bulk_get(&pdev->dev, icl->num_regulators,
icl->regulators);
if (ret < 0)
return ret;
icd->iface = icl->bus_id; icd->iface = icl->bus_id;
icd->link = icl; icd->link = icl;
icd->pdev = &pdev->dev; icd->pdev = &pdev->dev;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment