Commit 9047fa5d authored by Wei Yongjun's avatar Wei Yongjun Committed by David S. Miller

phy: phy-ocelot-serdes: fix return value check in serdes_probe()

In case of error, the function syscon_node_to_regmap() returns ERR_PTR()
and never returns NULL. The NULL test in the return value check should
be replaced with IS_ERR().

Fixes: 51f6b410 ("phy: add driver for Microsemi Ocelot SerDes muxing")
Signed-off-by: default avatarWei Yongjun <weiyongjun1@huawei.com>
Reviewed-by: default avatarQuentin Schulz <quentin.schulz@bootlin.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 302d20e5
...@@ -257,8 +257,8 @@ static int serdes_probe(struct platform_device *pdev) ...@@ -257,8 +257,8 @@ static int serdes_probe(struct platform_device *pdev)
ctrl->dev = &pdev->dev; ctrl->dev = &pdev->dev;
ctrl->regs = syscon_node_to_regmap(pdev->dev.parent->of_node); ctrl->regs = syscon_node_to_regmap(pdev->dev.parent->of_node);
if (!ctrl->regs) if (IS_ERR(ctrl->regs))
return -ENODEV; return PTR_ERR(ctrl->regs);
for (i = 0; i <= SERDES_MAX; i++) { for (i = 0; i <= SERDES_MAX; i++) {
ret = serdes_phy_create(ctrl, i, &ctrl->phys[i]); ret = serdes_phy_create(ctrl, i, &ctrl->phys[i]);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment