Commit 98cdcd6c authored by Zheyu Ma's avatar Zheyu Ma Committed by Martin K. Petersen

scsi: wd719x: Return proper error code when dma_set_mask() fails

During the process of driver probing, the probe function should return < 0
for failure, otherwise the kernel will treat value >= 0 as success.

Set 'err' to the error value returned by dma_set_mask() in case of failure.

Link: https://lore.kernel.org/r/1646060055-11361-1-git-send-email-zheyuma97@gmail.comReviewed-by: default avatarJohannes Thumshirn <johannes.thumshirn@wdc.com>
Signed-off-by: default avatarZheyu Ma <zheyuma97@gmail.com>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent 69af1c95
...@@ -904,7 +904,8 @@ static int wd719x_pci_probe(struct pci_dev *pdev, const struct pci_device_id *d) ...@@ -904,7 +904,8 @@ static int wd719x_pci_probe(struct pci_dev *pdev, const struct pci_device_id *d)
if (err) if (err)
goto fail; goto fail;
if (dma_set_mask(&pdev->dev, DMA_BIT_MASK(32))) { err = dma_set_mask(&pdev->dev, DMA_BIT_MASK(32));
if (err) {
dev_warn(&pdev->dev, "Unable to set 32-bit DMA mask\n"); dev_warn(&pdev->dev, "Unable to set 32-bit DMA mask\n");
goto disable_device; goto disable_device;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment