Commit 9af6100f authored by Hans de Goede's avatar Hans de Goede Committed by Mauro Carvalho Chehab

media: atomisp: Remove unused fields from struct atomisp_input_subdev

Remove unused fields from struct atomisp_input_subdev:

1. frame_size is never used at all
2. sensor_index is always 0, just directly pass 0 in the single user.

Link: https://lore.kernel.org/r/20230518153733.195306-3-hdegoede@redhat.comReviewed-by: default avatarAndy Shevchenko <andy.shevchenko@gmail.com>
Signed-off-by: default avatarHans de Goede <hdegoede@redhat.com>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@kernel.org>
parent 1ad997e8
...@@ -126,15 +126,12 @@ struct atomisp_input_subdev { ...@@ -126,15 +126,12 @@ struct atomisp_input_subdev {
enum atomisp_camera_port port; enum atomisp_camera_port port;
struct v4l2_subdev *camera; struct v4l2_subdev *camera;
struct v4l2_subdev *motor; struct v4l2_subdev *motor;
struct v4l2_frmsizeenum frame_size;
/* /*
* To show this resource is used by * To show this resource is used by
* which stream, in ISP multiple stream mode * which stream, in ISP multiple stream mode
*/ */
struct atomisp_sub_device *asd; struct atomisp_sub_device *asd;
int sensor_index;
}; };
enum atomisp_dfs_mode { enum atomisp_dfs_mode {
......
...@@ -673,7 +673,7 @@ static int atomisp_s_input(struct file *file, void *fh, unsigned int input) ...@@ -673,7 +673,7 @@ static int atomisp_s_input(struct file *file, void *fh, unsigned int input)
/* select operating sensor */ /* select operating sensor */
ret = v4l2_subdev_call(isp->inputs[input].camera, video, s_routing, ret = v4l2_subdev_call(isp->inputs[input].camera, video, s_routing,
0, isp->inputs[input].sensor_index, 0); 0, 0, 0);
if (ret && (ret != -ENOIOCTLCMD)) { if (ret && (ret != -ENOIOCTLCMD)) {
dev_err(isp->dev, "Failed to select sensor\n"); dev_err(isp->dev, "Failed to select sensor\n");
return ret; return ret;
......
...@@ -866,13 +866,6 @@ static int atomisp_subdev_probe(struct atomisp_device *isp) ...@@ -866,13 +866,6 @@ static int atomisp_subdev_probe(struct atomisp_device *isp)
isp->inputs[isp->input_cnt].type = subdevs->type; isp->inputs[isp->input_cnt].type = subdevs->type;
isp->inputs[isp->input_cnt].port = subdevs->port; isp->inputs[isp->input_cnt].port = subdevs->port;
isp->inputs[isp->input_cnt].camera = subdevs->subdev; isp->inputs[isp->input_cnt].camera = subdevs->subdev;
isp->inputs[isp->input_cnt].sensor_index = 0;
/*
* initialize the subdev frame size, then next we can
* judge whether frame_size store effective value via
* pixel_format.
*/
isp->inputs[isp->input_cnt].frame_size.pixel_format = 0;
isp->input_cnt++; isp->input_cnt++;
break; break;
case CAMERA_MOTOR: case CAMERA_MOTOR:
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment