Commit 9d504f9a authored by Jisheng Zhang's avatar Jisheng Zhang Committed by Palmer Dabbelt

riscv: lib: uaccess: fold fixups into body

uaccess functions such __asm_copy_to_user(),  __arch_copy_from_user()
and __clear_user() place their exception fixups in the `.fixup` section
without any clear association with themselves. If we backtrace the
fixup code, it will be symbolized as an offset from the nearest prior
symbol.

Similar as arm64 does, we must move fixups into the body of the
functions themselves, after the usual fast-path returns.
Signed-off-by: default avatarJisheng Zhang <jszhang@kernel.org>
Signed-off-by: default avatarPalmer Dabbelt <palmer@rivosinc.com>
parent 4c2e7ce8
...@@ -173,6 +173,13 @@ ENTRY(__asm_copy_from_user) ...@@ -173,6 +173,13 @@ ENTRY(__asm_copy_from_user)
csrc CSR_STATUS, t6 csrc CSR_STATUS, t6
li a0, 0 li a0, 0
ret ret
/* Exception fixup code */
10:
/* Disable access to user memory */
csrs CSR_STATUS, t6
mv a0, t5
ret
ENDPROC(__asm_copy_to_user) ENDPROC(__asm_copy_to_user)
ENDPROC(__asm_copy_from_user) ENDPROC(__asm_copy_from_user)
EXPORT_SYMBOL(__asm_copy_to_user) EXPORT_SYMBOL(__asm_copy_to_user)
...@@ -218,19 +225,12 @@ ENTRY(__clear_user) ...@@ -218,19 +225,12 @@ ENTRY(__clear_user)
addi a0, a0, 1 addi a0, a0, 1
bltu a0, a3, 5b bltu a0, a3, 5b
j 3b j 3b
ENDPROC(__clear_user)
EXPORT_SYMBOL(__clear_user)
.section .fixup,"ax" /* Exception fixup code */
.balign 4
/* Fixup code for __copy_user(10) and __clear_user(11) */
10:
/* Disable access to user memory */
csrs CSR_STATUS, t6
mv a0, t5
ret
11: 11:
/* Disable access to user memory */
csrs CSR_STATUS, t6 csrs CSR_STATUS, t6
mv a0, a1 mv a0, a1
ret ret
.previous ENDPROC(__clear_user)
EXPORT_SYMBOL(__clear_user)
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment