Commit a118fc6e authored by Uwe Kleine-König's avatar Uwe Kleine-König Committed by Douglas Anderson

drm/atmel-hlcdc: Convert to platform remove callback returning void

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is (mostly) ignored
and this typically results in resource leaks. To improve here there is a
quest to make the remove callback return void. In the first step of this
quest all drivers are converted to .remove_new() which already returns
void.

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.
Signed-off-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Acked-by: default avatarSam Ravnborg <sam@ravnborg.org>
Reviewed-by: default avatarClaudiu Beznea <claudiu.beznea@microchip.com>
Signed-off-by: default avatarDouglas Anderson <dianders@chromium.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20230507162616.1368908-7-u.kleine-koenig@pengutronix.de
parent 9a32dd32
...@@ -773,15 +773,13 @@ static int atmel_hlcdc_dc_drm_probe(struct platform_device *pdev) ...@@ -773,15 +773,13 @@ static int atmel_hlcdc_dc_drm_probe(struct platform_device *pdev)
return ret; return ret;
} }
static int atmel_hlcdc_dc_drm_remove(struct platform_device *pdev) static void atmel_hlcdc_dc_drm_remove(struct platform_device *pdev)
{ {
struct drm_device *ddev = platform_get_drvdata(pdev); struct drm_device *ddev = platform_get_drvdata(pdev);
drm_dev_unregister(ddev); drm_dev_unregister(ddev);
atmel_hlcdc_dc_unload(ddev); atmel_hlcdc_dc_unload(ddev);
drm_dev_put(ddev); drm_dev_put(ddev);
return 0;
} }
static int atmel_hlcdc_dc_drm_suspend(struct device *dev) static int atmel_hlcdc_dc_drm_suspend(struct device *dev)
...@@ -826,7 +824,7 @@ static const struct of_device_id atmel_hlcdc_dc_of_match[] = { ...@@ -826,7 +824,7 @@ static const struct of_device_id atmel_hlcdc_dc_of_match[] = {
static struct platform_driver atmel_hlcdc_dc_platform_driver = { static struct platform_driver atmel_hlcdc_dc_platform_driver = {
.probe = atmel_hlcdc_dc_drm_probe, .probe = atmel_hlcdc_dc_drm_probe,
.remove = atmel_hlcdc_dc_drm_remove, .remove_new = atmel_hlcdc_dc_drm_remove,
.driver = { .driver = {
.name = "atmel-hlcdc-display-controller", .name = "atmel-hlcdc-display-controller",
.pm = pm_sleep_ptr(&atmel_hlcdc_dc_drm_pm_ops), .pm = pm_sleep_ptr(&atmel_hlcdc_dc_drm_pm_ops),
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment