Commit a129b41f authored by Francesco Dolcini's avatar Francesco Dolcini Committed by Jakub Kicinski

Revert "net: phy: dp83867: perform soft reset and retain established link"

This reverts commit da9ef50f.

This fixes a regression in which the link would come up, but no
communication was possible.

The reverted commit was also removing a comment about
DP83867_PHYCR_FORCE_LINK_GOOD, this is not added back in this commits
since it seems that this is unrelated to the original code change.

Closes: https://lore.kernel.org/all/ZGuDJos8D7N0J6Z2@francesco-nb.int.toradex.com/
Fixes: da9ef50f ("net: phy: dp83867: perform soft reset and retain established link")
Signed-off-by: default avatarFrancesco Dolcini <francesco.dolcini@toradex.com>
Reviewed-by: default avatarAndrew Lunn <andrew@lunn.ch>
Reviewed-by: default avatarPraneeth Bajjuri <praneeth@ti.com>
Link: https://lore.kernel.org/r/20230619154435.355485-1-francesco@dolcini.itSigned-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 408c0900
...@@ -936,7 +936,7 @@ static int dp83867_phy_reset(struct phy_device *phydev) ...@@ -936,7 +936,7 @@ static int dp83867_phy_reset(struct phy_device *phydev)
{ {
int err; int err;
err = phy_write(phydev, DP83867_CTRL, DP83867_SW_RESTART); err = phy_write(phydev, DP83867_CTRL, DP83867_SW_RESET);
if (err < 0) if (err < 0)
return err; return err;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment