Commit a1ad38a6 authored by Bryant G. Ly's avatar Bryant G. Ly Committed by Martin K. Petersen

scsi: ibmvscsi_tgt: Remove target_wait_for_sess_cmd()

There is currently a bug with the driver where there is never a call to
target_sess_cmd_list_set_waiting(), it only called
target_wait_for_sess_cmd(), which basically means that the sess_wait_list
would always be empty.

Thus, list_empty(&sess->sess_wait_list) = true,
(eg: no se_cmd I/O is quiesced, because no se_cmd in sess_wait_list),
since commit 712db3eb ("scsi: ibmvscsis: Properly deregister
target sessions") in 4.9.y code.

ibmvscsi_tgt does not remove the I_T Nexus when a VM is active so we can
fix this issue by removing the call to target_wait_for_sess_cmd()
altogether.
Signed-off-by: default avatarBryant G. Ly <bly@catalogicsoftware.com>
Reviewed-by: default avatarMike Christie <mchristi@redhat.com>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent f4bb7704
...@@ -2266,7 +2266,6 @@ static int ibmvscsis_drop_nexus(struct ibmvscsis_tport *tport) ...@@ -2266,7 +2266,6 @@ static int ibmvscsis_drop_nexus(struct ibmvscsis_tport *tport)
/* /*
* Release the SCSI I_T Nexus to the emulated ibmvscsis Target Port * Release the SCSI I_T Nexus to the emulated ibmvscsis Target Port
*/ */
target_wait_for_sess_cmds(se_sess);
target_remove_session(se_sess); target_remove_session(se_sess);
tport->ibmv_nexus = NULL; tport->ibmv_nexus = NULL;
kfree(nexus); kfree(nexus);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment