Commit a263a840 authored by Akhil R's avatar Akhil R Committed by Wolfram Sang

i2c: smbus: Use device_*() functions instead of of_*()

Change of_*() functions to device_*() for firmware agnostic usage.
This allows to have the smbus_alert interrupt without any changes
in the controller drivers using the ACPI table.
Signed-off-by: default avatarAkhil R <akhilrajeev@nvidia.com>
Reviewed-by: default avatarAndy Shevchenko <andy.shevchenko@gmail.com>
Signed-off-by: default avatarWolfram Sang <wsa@kernel.org>
parent 20e8ef5c
...@@ -1479,7 +1479,7 @@ static int i2c_register_adapter(struct i2c_adapter *adap) ...@@ -1479,7 +1479,7 @@ static int i2c_register_adapter(struct i2c_adapter *adap)
goto out_list; goto out_list;
} }
res = of_i2c_setup_smbus_alert(adap); res = i2c_setup_smbus_alert(adap);
if (res) if (res)
goto out_reg; goto out_reg;
......
...@@ -14,6 +14,7 @@ ...@@ -14,6 +14,7 @@
#include <linux/err.h> #include <linux/err.h>
#include <linux/i2c.h> #include <linux/i2c.h>
#include <linux/i2c-smbus.h> #include <linux/i2c-smbus.h>
#include <linux/property.h>
#include <linux/slab.h> #include <linux/slab.h>
#include "i2c-core.h" #include "i2c-core.h"
...@@ -701,12 +702,12 @@ struct i2c_client *i2c_new_smbus_alert_device(struct i2c_adapter *adapter, ...@@ -701,12 +702,12 @@ struct i2c_client *i2c_new_smbus_alert_device(struct i2c_adapter *adapter,
} }
EXPORT_SYMBOL_GPL(i2c_new_smbus_alert_device); EXPORT_SYMBOL_GPL(i2c_new_smbus_alert_device);
#if IS_ENABLED(CONFIG_I2C_SMBUS) && IS_ENABLED(CONFIG_OF) #if IS_ENABLED(CONFIG_I2C_SMBUS)
int of_i2c_setup_smbus_alert(struct i2c_adapter *adapter) int i2c_setup_smbus_alert(struct i2c_adapter *adapter)
{ {
int irq; int irq;
irq = of_property_match_string(adapter->dev.of_node, "interrupt-names", irq = device_property_match_string(adapter->dev.parent, "interrupt-names",
"smbus_alert"); "smbus_alert");
if (irq == -EINVAL || irq == -ENODATA) if (irq == -EINVAL || irq == -ENODATA)
return 0; return 0;
...@@ -715,5 +716,5 @@ int of_i2c_setup_smbus_alert(struct i2c_adapter *adapter) ...@@ -715,5 +716,5 @@ int of_i2c_setup_smbus_alert(struct i2c_adapter *adapter)
return PTR_ERR_OR_ZERO(i2c_new_smbus_alert_device(adapter, NULL)); return PTR_ERR_OR_ZERO(i2c_new_smbus_alert_device(adapter, NULL));
} }
EXPORT_SYMBOL_GPL(of_i2c_setup_smbus_alert); EXPORT_SYMBOL_GPL(i2c_setup_smbus_alert);
#endif #endif
...@@ -13,7 +13,7 @@ ...@@ -13,7 +13,7 @@
#include <linux/interrupt.h> #include <linux/interrupt.h>
#include <linux/kernel.h> #include <linux/kernel.h>
#include <linux/module.h> #include <linux/module.h>
#include <linux/of_irq.h> #include <linux/property.h>
#include <linux/slab.h> #include <linux/slab.h>
#include <linux/workqueue.h> #include <linux/workqueue.h>
...@@ -128,7 +128,8 @@ static int smbalert_probe(struct i2c_client *ara, ...@@ -128,7 +128,8 @@ static int smbalert_probe(struct i2c_client *ara,
if (setup) { if (setup) {
irq = setup->irq; irq = setup->irq;
} else { } else {
irq = of_irq_get_byname(adapter->dev.of_node, "smbus_alert"); irq = fwnode_irq_get_byname(dev_fwnode(adapter->dev.parent),
"smbus_alert");
if (irq <= 0) if (irq <= 0)
return irq; return irq;
} }
......
...@@ -30,10 +30,10 @@ struct i2c_client *i2c_new_smbus_alert_device(struct i2c_adapter *adapter, ...@@ -30,10 +30,10 @@ struct i2c_client *i2c_new_smbus_alert_device(struct i2c_adapter *adapter,
struct i2c_smbus_alert_setup *setup); struct i2c_smbus_alert_setup *setup);
int i2c_handle_smbus_alert(struct i2c_client *ara); int i2c_handle_smbus_alert(struct i2c_client *ara);
#if IS_ENABLED(CONFIG_I2C_SMBUS) && IS_ENABLED(CONFIG_OF) #if IS_ENABLED(CONFIG_I2C_SMBUS)
int of_i2c_setup_smbus_alert(struct i2c_adapter *adap); int i2c_setup_smbus_alert(struct i2c_adapter *adap);
#else #else
static inline int of_i2c_setup_smbus_alert(struct i2c_adapter *adap) static inline int i2c_setup_smbus_alert(struct i2c_adapter *adap)
{ {
return 0; return 0;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment