Commit a3781639 authored by Vladimir Zapolskiy's avatar Vladimir Zapolskiy Committed by Alexandre Belloni

rtc: cmos: clean up cmos_nvram_read()/cmos_nvram_write()

The change removes redundant sysfs binary file boundary checks, since
this task is already done on caller side in fs/sysfs/file.c
Signed-off-by: default avatarVladimir Zapolskiy <vz@mleia.com>
Signed-off-by: default avatarAlexandre Belloni <alexandre.belloni@free-electrons.com>
parent 3c217e51
...@@ -467,13 +467,6 @@ cmos_nvram_read(struct file *filp, struct kobject *kobj, ...@@ -467,13 +467,6 @@ cmos_nvram_read(struct file *filp, struct kobject *kobj,
{ {
int retval; int retval;
if (unlikely(off >= attr->size))
return 0;
if (unlikely(off < 0))
return -EINVAL;
if ((off + count) > attr->size)
count = attr->size - off;
off += NVRAM_OFFSET; off += NVRAM_OFFSET;
spin_lock_irq(&rtc_lock); spin_lock_irq(&rtc_lock);
for (retval = 0; count; count--, off++, retval++) { for (retval = 0; count; count--, off++, retval++) {
...@@ -498,12 +491,6 @@ cmos_nvram_write(struct file *filp, struct kobject *kobj, ...@@ -498,12 +491,6 @@ cmos_nvram_write(struct file *filp, struct kobject *kobj,
int retval; int retval;
cmos = dev_get_drvdata(container_of(kobj, struct device, kobj)); cmos = dev_get_drvdata(container_of(kobj, struct device, kobj));
if (unlikely(off >= attr->size))
return -EFBIG;
if (unlikely(off < 0))
return -EINVAL;
if ((off + count) > attr->size)
count = attr->size - off;
/* NOTE: on at least PCs and Ataris, the boot firmware uses a /* NOTE: on at least PCs and Ataris, the boot firmware uses a
* checksum on part of the NVRAM data. That's currently ignored * checksum on part of the NVRAM data. That's currently ignored
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment