Commit aa7fc0ca authored by Alexandre Courbot's avatar Alexandre Courbot Committed by Dave Airlie

drm/nouveau/secboot: fix inconsistent pointer checking

We were returning PTR_ERR() on a NULL pointer, which obviously won't
work. nvkm_engine_ref() will return an error in case something went
wrong.
Signed-off-by: default avatarAlexandre Courbot <acourbot@nvidia.com>
Reported-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarDave Airlie <airlied@redhat.com>
parent 9c233760
...@@ -59,7 +59,8 @@ gp102_run_secure_scrub(struct nvkm_secboot *sb) ...@@ -59,7 +59,8 @@ gp102_run_secure_scrub(struct nvkm_secboot *sb)
nvkm_debug(subdev, "running VPR scrubber binary on NVDEC...\n"); nvkm_debug(subdev, "running VPR scrubber binary on NVDEC...\n");
if (!(engine = nvkm_engine_ref(&device->nvdec->engine))) engine = nvkm_engine_ref(&device->nvdec->engine);
if (IS_ERR(engine))
return PTR_ERR(engine); return PTR_ERR(engine);
falcon = device->nvdec->falcon; falcon = device->nvdec->falcon;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment