Commit ae374a30 authored by James Smart's avatar James Smart Committed by James Bottomley

lpfc: Fix scsi task management error message.

TMF's were getting error messages on FCP_RSP errors (underrun). Underruns
aren't meaningful in the scenario. Change the error message to filter out
these response check errors, and don't unconditionally mark the cmd as
in error.
Signed-off-by: default avatarDick Kennedy <dick.kennedy@avagotech.com>
Signed-off-by: default avatarJames Smart <james.smart@avagotech.com>
Reviewed-by: default avatarHannes Reinecke <hare@suse.de>
Signed-off-by: default avatarJames Bottomley <JBottomley@Odin.com>
parent 16f3b48d
...@@ -5011,13 +5011,16 @@ lpfc_send_taskmgmt(struct lpfc_vport *vport, struct lpfc_rport_data *rdata, ...@@ -5011,13 +5011,16 @@ lpfc_send_taskmgmt(struct lpfc_vport *vport, struct lpfc_rport_data *rdata,
iocbq, iocbqrsp, lpfc_cmd->timeout); iocbq, iocbqrsp, lpfc_cmd->timeout);
if ((status != IOCB_SUCCESS) || if ((status != IOCB_SUCCESS) ||
(iocbqrsp->iocb.ulpStatus != IOSTAT_SUCCESS)) { (iocbqrsp->iocb.ulpStatus != IOSTAT_SUCCESS)) {
lpfc_printf_vlog(vport, KERN_ERR, LOG_FCP, if (status != IOCB_SUCCESS ||
"0727 TMF %s to TGT %d LUN %llu failed (%d, %d) " iocbqrsp->iocb.ulpStatus != IOSTAT_FCP_RSP_ERROR)
"iocb_flag x%x\n", lpfc_printf_vlog(vport, KERN_ERR, LOG_FCP,
lpfc_taskmgmt_name(task_mgmt_cmd), "0727 TMF %s to TGT %d LUN %llu "
tgt_id, lun_id, iocbqrsp->iocb.ulpStatus, "failed (%d, %d) iocb_flag x%x\n",
iocbqrsp->iocb.un.ulpWord[4], lpfc_taskmgmt_name(task_mgmt_cmd),
iocbq->iocb_flag); tgt_id, lun_id,
iocbqrsp->iocb.ulpStatus,
iocbqrsp->iocb.un.ulpWord[4],
iocbq->iocb_flag);
/* if ulpStatus != IOCB_SUCCESS, then status == IOCB_SUCCESS */ /* if ulpStatus != IOCB_SUCCESS, then status == IOCB_SUCCESS */
if (status == IOCB_SUCCESS) { if (status == IOCB_SUCCESS) {
if (iocbqrsp->iocb.ulpStatus == IOSTAT_FCP_RSP_ERROR) if (iocbqrsp->iocb.ulpStatus == IOSTAT_FCP_RSP_ERROR)
...@@ -5031,7 +5034,6 @@ lpfc_send_taskmgmt(struct lpfc_vport *vport, struct lpfc_rport_data *rdata, ...@@ -5031,7 +5034,6 @@ lpfc_send_taskmgmt(struct lpfc_vport *vport, struct lpfc_rport_data *rdata,
} else { } else {
ret = FAILED; ret = FAILED;
} }
lpfc_cmd->status = IOSTAT_DRIVER_REJECT;
} else } else
ret = SUCCESS; ret = SUCCESS;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment