Commit afcecca5 authored by Michael Walle's avatar Michael Walle Committed by David S. Miller

net: phy: bcm54140: fix phy_id_mask

Broadcom defines the bits for this PHY as follows:
  { oui[24:3], model[6:0], revision[2:0] }

Thus we have to mask the lower three bits only.

Fixes: 6937602e ("net: phy: add Broadcom BCM54140 support")
Signed-off-by: default avatarMichael Walle <michael@walle.cc>
Reviewed-by: default avatarAndrew Lunn <andrew@lunn.ch>
Reviewed-by: default avatarFlorian Fainelli <f.fainelli@gmail.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 86570d8a
...@@ -852,7 +852,7 @@ static int bcm54140_set_tunable(struct phy_device *phydev, ...@@ -852,7 +852,7 @@ static int bcm54140_set_tunable(struct phy_device *phydev,
static struct phy_driver bcm54140_drivers[] = { static struct phy_driver bcm54140_drivers[] = {
{ {
.phy_id = PHY_ID_BCM54140, .phy_id = PHY_ID_BCM54140,
.phy_id_mask = 0xfffffff0, .phy_id_mask = 0xfffffff8,
.name = "Broadcom BCM54140", .name = "Broadcom BCM54140",
.features = PHY_GBIT_FEATURES, .features = PHY_GBIT_FEATURES,
.config_init = bcm54140_config_init, .config_init = bcm54140_config_init,
...@@ -870,7 +870,7 @@ static struct phy_driver bcm54140_drivers[] = { ...@@ -870,7 +870,7 @@ static struct phy_driver bcm54140_drivers[] = {
module_phy_driver(bcm54140_drivers); module_phy_driver(bcm54140_drivers);
static struct mdio_device_id __maybe_unused bcm54140_tbl[] = { static struct mdio_device_id __maybe_unused bcm54140_tbl[] = {
{ PHY_ID_BCM54140, 0xfffffff0 }, { PHY_ID_BCM54140, 0xfffffff8 },
{ } { }
}; };
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment