Commit b3494ccb authored by Douglas Anderson's avatar Douglas Anderson Committed by Neil Armstrong

drm/panel: sharp-ls043t1le01: Don't call disable at shutdown/remove

It's the responsibility of a correctly written DRM modeset driver to
call drm_atomic_helper_shutdown() at shutdown time and that should be
disabling / unpreparing the panel if needed. Panel drivers shouldn't
be calling these functions themselves.

A recent effort was made to fix as many DRM modeset drivers as
possible [1] [2] [3] and most drivers are fixed now.

A grep through mainline for compatible strings used by this driver
indicates that it is used by Qualcomm boards. The Qualcomm driver
appears to be correctly calling drm_atomic_helper_shutdown() so we can
remove the calls.

[1] https://lore.kernel.org/r/20230901234015.566018-1-dianders@chromium.org
[2] https://lore.kernel.org/r/20230901234202.566951-1-dianders@chromium.org
[3] https://lore.kernel.org/r/20230921192749.1542462-1-dianders@chromium.org

Cc: Werner Johansson <werner.johansson@sonymobile.com>
Cc: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Acked-by: default avatarLinus Walleij <linus.walleij@linaro.org>
Acked-by: default avatarMaxime Ripard <mripard@kernel.org>
Signed-off-by: default avatarDouglas Anderson <dianders@chromium.org>
Reviewed-by: default avatarNeil Armstrong <neil.armstrong@linaro.org>
Link: https://lore.kernel.org/r/20240604172305.v3.20.I89ee53f7fc2f0806cab318128e5fa927990d830f@changeidSigned-off-by: default avatarNeil Armstrong <neil.armstrong@linaro.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20240604172305.v3.20.I89ee53f7fc2f0806cab318128e5fa927990d830f@changeid
parent 804c4d0a
...@@ -267,10 +267,6 @@ static void sharp_nt_panel_remove(struct mipi_dsi_device *dsi) ...@@ -267,10 +267,6 @@ static void sharp_nt_panel_remove(struct mipi_dsi_device *dsi)
struct sharp_nt_panel *sharp_nt = mipi_dsi_get_drvdata(dsi); struct sharp_nt_panel *sharp_nt = mipi_dsi_get_drvdata(dsi);
int ret; int ret;
ret = drm_panel_disable(&sharp_nt->base);
if (ret < 0)
dev_err(&dsi->dev, "failed to disable panel: %d\n", ret);
ret = mipi_dsi_detach(dsi); ret = mipi_dsi_detach(dsi);
if (ret < 0) if (ret < 0)
dev_err(&dsi->dev, "failed to detach from DSI host: %d\n", ret); dev_err(&dsi->dev, "failed to detach from DSI host: %d\n", ret);
...@@ -278,13 +274,6 @@ static void sharp_nt_panel_remove(struct mipi_dsi_device *dsi) ...@@ -278,13 +274,6 @@ static void sharp_nt_panel_remove(struct mipi_dsi_device *dsi)
sharp_nt_panel_del(sharp_nt); sharp_nt_panel_del(sharp_nt);
} }
static void sharp_nt_panel_shutdown(struct mipi_dsi_device *dsi)
{
struct sharp_nt_panel *sharp_nt = mipi_dsi_get_drvdata(dsi);
drm_panel_disable(&sharp_nt->base);
}
static const struct of_device_id sharp_nt_of_match[] = { static const struct of_device_id sharp_nt_of_match[] = {
{ .compatible = "sharp,ls043t1le01-qhd", }, { .compatible = "sharp,ls043t1le01-qhd", },
{ } { }
...@@ -298,7 +287,6 @@ static struct mipi_dsi_driver sharp_nt_panel_driver = { ...@@ -298,7 +287,6 @@ static struct mipi_dsi_driver sharp_nt_panel_driver = {
}, },
.probe = sharp_nt_panel_probe, .probe = sharp_nt_panel_probe,
.remove = sharp_nt_panel_remove, .remove = sharp_nt_panel_remove,
.shutdown = sharp_nt_panel_shutdown,
}; };
module_mipi_dsi_driver(sharp_nt_panel_driver); module_mipi_dsi_driver(sharp_nt_panel_driver);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment