Commit b4010beb authored by Parthiban Veerasooran's avatar Parthiban Veerasooran Committed by Paolo Abeni

net: phy: microchip_t1s: remove unnecessary interrupts disabling code

By default, except Reset Complete interrupt in the Interrupt Mask 2
Register all other interrupts are disabled/masked. As Reset Complete
status is already handled, it doesn't make sense to disable it.
Reviewed-by: default avatarRamón Nordin Rodriguez <ramon.nordin.rodriguez@ferroamp.se>
Tested-by: default avatarRamón Nordin Rodriguez <ramon.nordin.rodriguez@ferroamp.se>
Reviewed-by: default avatarAndrew Lunn <andrew@lunn.ch>
Signed-off-by: default avatarParthiban Veerasooran <Parthiban.Veerasooran@microchip.com>
Signed-off-by: default avatarPaolo Abeni <pabeni@redhat.com>
parent 1d7650b8
...@@ -12,8 +12,6 @@ ...@@ -12,8 +12,6 @@
#define PHY_ID_LAN867X_REVB1 0x0007C162 #define PHY_ID_LAN867X_REVB1 0x0007C162
#define LAN867X_REG_IRQ_1_CTL 0x001C
#define LAN867X_REG_IRQ_2_CTL 0x001D
#define LAN867X_REG_STS2 0x0019 #define LAN867X_REG_STS2 0x0019
#define LAN867x_RESET_COMPLETE_STS BIT(11) #define LAN867x_RESET_COMPLETE_STS BIT(11)
...@@ -89,17 +87,7 @@ static int lan867x_revb1_config_init(struct phy_device *phydev) ...@@ -89,17 +87,7 @@ static int lan867x_revb1_config_init(struct phy_device *phydev)
return err; return err;
} }
/* None of the interrupts in the lan867x phy seem relevant. return 0;
* Other phys inspect the link status and call phy_trigger_machine
* in the interrupt handler.
* This phy does not support link status, and thus has no interrupt
* for it either.
* So we'll just disable all interrupts on the chip.
*/
err = phy_write_mmd(phydev, MDIO_MMD_VEND2, LAN867X_REG_IRQ_1_CTL, 0xFFFF);
if (err != 0)
return err;
return phy_write_mmd(phydev, MDIO_MMD_VEND2, LAN867X_REG_IRQ_2_CTL, 0xFFFF);
} }
static int lan867x_read_status(struct phy_device *phydev) static int lan867x_read_status(struct phy_device *phydev)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment