Commit b5b6c7ee authored by Matt Fleming's avatar Matt Fleming Committed by Paul Mundt

sh: Replace unsafe manipulation of MMUCR

Setting the TI in MMUCR causes all the TLB bits in MMUCR to be
cleared. Unfortunately, the TLB wired bits are also cleared when setting
the TI bit, causing any wired TLB entries to become unwired.

Use local_flush_tlb_all() which implements TLB flushing in a safer
manner by using the memory-mapped TLB registers. As each CPU has its own
PMB the modifications in pmb_init() only affect the local CPU, so only
flush the local CPU's TLB.
Signed-off-by: default avatarMatt Fleming <matt@console-pimps.org>
Signed-off-by: default avatarPaul Mundt <lethal@linux-sh.org>
parent a9eb4f6d
...@@ -802,7 +802,7 @@ void __init pmb_init(void) ...@@ -802,7 +802,7 @@ void __init pmb_init(void)
writel_uncached(0, PMB_IRMCR); writel_uncached(0, PMB_IRMCR);
/* Flush out the TLB */ /* Flush out the TLB */
__raw_writel(__raw_readl(MMUCR) | MMUCR_TI, MMUCR); local_flush_tlb_all();
ctrl_barrier(); ctrl_barrier();
} }
......
...@@ -123,18 +123,27 @@ void local_flush_tlb_mm(struct mm_struct *mm) ...@@ -123,18 +123,27 @@ void local_flush_tlb_mm(struct mm_struct *mm)
void local_flush_tlb_all(void) void local_flush_tlb_all(void)
{ {
unsigned long flags, status; unsigned long flags, status;
int i;
/* /*
* Flush all the TLB. * Flush all the TLB.
*
* Write to the MMU control register's bit:
* TF-bit for SH-3, TI-bit for SH-4.
* It's same position, bit #2.
*/ */
local_irq_save(flags); local_irq_save(flags);
jump_to_uncached();
status = __raw_readl(MMUCR); status = __raw_readl(MMUCR);
status |= 0x04; status = ((status & MMUCR_URB) >> MMUCR_URB_SHIFT);
__raw_writel(status, MMUCR);
if (status == 0)
status = MMUCR_URB_NENTRIES;
for (i = 0; i < status; i++)
__raw_writel(0x0, MMU_UTLB_ADDRESS_ARRAY | (i << 8));
for (i = 0; i < 4; i++)
__raw_writel(0x0, MMU_ITLB_ADDRESS_ARRAY | (i << 8));
back_to_cached();
ctrl_barrier(); ctrl_barrier();
local_irq_restore(flags); local_irq_restore(flags);
} }
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment